Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pagination support for Receipts #15

Closed
guerrillacontra opened this issue Aug 18, 2022 · 1 comment
Closed

Enable pagination support for Receipts #15

guerrillacontra opened this issue Aug 18, 2022 · 1 comment

Comments

@guerrillacontra
Copy link

It should be supported based on the official docs (offset+limit)

https://developers.etsy.com/documentation/reference#operation/getShopReceipts

But in Collection we have:

const PAGINATION_SUPPORT = [
"Shop", "Review", "Listing"
];

Which prevents me from being able to pull in more than 100 orders without writing my own paginator.

$receipts = $shop->getReceipts([
'limit'=>y,
'offset'=>y
]);

@rhysnhall
Copy link
Owner

Thanks for bringing this up @guerrillacontra
At the time of writing, the API did not support this. Good to see they have added it.
I have fallen behind on keeping up to date with their changes. I have also reviewed and added pagination support for Transactions and LedgerEntry.

Patch incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants