Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: knadh/listmonk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rhnvrm/listmonk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 21 files changed
  • 1 contributor

Commits on Sep 23, 2020

  1. refactor: switch to internal app package from main 

    This commit moves all the logic in the main package
to a new internal app package and adds a new simpler main.go
to the cmd/app main package.

With this refactor we remove the global state during the init and
scoping the global vars that we had earlier. This might help with
testing (if needed) later on as well.

The biggest benefit of this refactor for new users and developers
is running `go run cmd/app/main.go` to get started with listmonk.
    @rhnvrm
    rhnvrm committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    f4c3beb View commit details
    Browse the repository at this point in the history
Loading