Ignore nBFT network devices in anaconda #5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: RHEL-46014 The dracut networking and the 95nvmf module are using ifname= kernel commandline arguments to pass desired network interface setup as parsed from the ACPI NBFT table. These are highly volatile values and often changing upon each boot. Thus avoid writing /etc/systemd/network interface link files by Anaconda for any 'nbft*' network interface as these are getting packed in initramfs, creating havoc and conflicts with the actual networking setup during early boot.
47322e4
to
e5adef8
Compare
e5adef8
to
dee2874
Compare
Resolves: RHEL-46014
Resolves: RHEL-46014
dee2874
to
3101fb1
Compare
tbzatek
approved these changes
Aug 6, 2024
|
/kickstart-test --testtype network |
|
/kickstart-test --testtype smoke |
jstodola
reviewed
Aug 9, 2024
| @@ -180,6 +180,10 @@ def _write_interface_rename_config(self, root, ifname_option_values, overwrite): | |||
| :type overwrite: bool | |||
| """ | |||
|
|
|||
| # Avoid link files for 'nbft' interfaces as it breaks Boot from NVM over TCP | |||
| ifname_option_values = [value for value in ifname_option_values | |||
| if not value.startswith('nbft')] | |||
There was a problem hiding this comment.
why not use the is_nbft_device function?
jkonecny12
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Would be great to have the code coverage, otherwise it looks good.
https://app.codecov.io/gh/rhinstaller/anaconda/pull/5771
Comment on lines
+114
to
+117
| if is_nbft_device(device_name): | ||
| log.debug("Ignoring nBFT device %s", device_name) | ||
| continue | ||
|
|
There was a problem hiding this comment.
I'm missing code coverage of this code.
There was a problem hiding this comment.
We don't have the code around covered at all, I am not able to add it today. It would involve quite some thinking and mocking.
I just added test for the new functions in utils (utils deserves coverage update as well)
Resolves: RHEL-46014
Resolves: RHEL-46014
Resolves: RHEL-46014
f03d45e
to
5ff4915
Compare
|
/kickstart-test --testtype network |
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.