-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore nBFT network devices in anaconda #5771
Conversation
Resolves: RHEL-46014 The dracut networking and the 95nvmf module are using ifname= kernel commandline arguments to pass desired network interface setup as parsed from the ACPI NBFT table. These are highly volatile values and often changing upon each boot. Thus avoid writing /etc/systemd/network interface link files by Anaconda for any 'nbft*' network interface as these are getting packed in initramfs, creating havoc and conflicts with the actual networking setup during early boot.
47322e4
to
e5adef8
Compare
e5adef8
to
dee2874
Compare
Resolves: RHEL-46014
Resolves: RHEL-46014
dee2874
to
3101fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on RHEL-9.5.0-20240731.4
, confirming all working as expected!
/kickstart-test --testtype network |
/kickstart-test --testtype smoke |
@@ -180,6 +180,10 @@ def _write_interface_rename_config(self, root, ifname_option_values, overwrite): | |||
:type overwrite: bool | |||
""" | |||
|
|||
# Avoid link files for 'nbft' interfaces as it breaks Boot from NVM over TCP | |||
ifname_option_values = [value for value in ifname_option_values | |||
if not value.startswith('nbft')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use the is_nbft_device
function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have the code coverage, otherwise it looks good.
https://app.codecov.io/gh/rhinstaller/anaconda/pull/5771
if is_nbft_device(device_name): | ||
log.debug("Ignoring nBFT device %s", device_name) | ||
continue | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing code coverage of this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have the code around covered at all, I am not able to add it today. It would involve quite some thinking and mocking.
I just added test for the new functions in utils (utils deserves coverage update as well)
Resolves: RHEL-46014
Resolves: RHEL-46014
Resolves: RHEL-46014
f03d45e
to
5ff4915
Compare
/kickstart-test --testtype network |
/kickstart-test --testtype smoke |
No description provided.