-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for running on Wayland through Weston #5401
base: master
Are you sure you want to change the base?
Conversation
Hello @Conan-Kudo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-20 00:43:20 UTC |
162372f
to
6abac9b
Compare
6abac9b
to
cd6f7ab
Compare
cd6f7ab
to
ed4288c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without understanding the problem domain, LGTM so far.
pyanaconda/core/util.py
Outdated
argv = ["weston", f"--config={weston_config_file}", "--log=/tmp/weston.log", | ||
f"--socket={WAYLAND_SOCKET_NAME}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't using f-strings anywhere else. Not sure if it means they can't be used at all, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f-strings were added in Python 3.6. I think it's pretty reasonable to state that we're probably not going to be running this Anaconda codebase on something older than that, since Python 3.6 is what RHEL 8 shipped with. I can certainly change it, but I liked how it make this easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it would be possible to use f-strings on the platforms we care about, it has been more a question of team policy or consistency so far not to use them in the Anaconda code.
sock.close() | ||
wl_status.started = True | ||
return wl_status.started | ||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be more specific than just Exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, I could, but I have intentionally not done so because I want it to happen in any exception case. It's merely for shorting the loop to iterate on the timeout.
ed4288c
to
ea21578
Compare
@VladimirSlavik, @jkonecny12, @M4rtinK: do any of you know what I'm doing wrong with the Autotools definition to add the PAM file? I'm not sure how to fix it... |
ea21578
to
2fb6f80
Compare
Ah, I figured it out now, and it looks like the package builds are going now. |
2fb6f80
to
c09c693
Compare
/build-image --boot.iso |
c09c693
to
9f70bee
Compare
Images built based on commit c09c693:
Download the images from the bottom of the job status page. |
/build-image --boot.iso |
Images built based on commit 9f70bee:
Download the images from the bottom of the job status page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Conan-Kudo Kudos on the awesome job, this contribution is in great state and I see it already uncovered some issues (Lorax templates)! 🌟
However, I've got a few thoughts about merging that I wanted to share.
Our team's got some recent "capacity challenges" post you might wanna check out: Check the post here. It paints a bit of the picture we're dealing with right now.
Here's the thing – about Weston, there's some uncertainty on downstream support (probably not at all), and keeping this as an upstream only change, means we are without the QE team on board, so this could create a headache for us maintenance-wise. Plus, we're in the trenches porting Anaconda to XWayland already, so probably there is some conflicting areas in your work with what @M4rtinK is currently working on.
I'm thinking it might be wise to keep this open and not merge it for now, aligning it with our current WIP changes towards xwayland but without introducing Fedora only solutions (Weston).
9f70bee
to
70b8821
Compare
@KKoukiou In general, I think what I'm working on and what @M4rtinK is working on will not conflict. Changing Anaconda's behaviors as an XWayland application is complementary to this. All this does is make it so that we run Anaconda as an XWayland application and wires up both the default and VNC modes to Weston as a Wayland compositor. There are separate work items that need to be done to further improve the experience, and @M4rtinK's work is positioned to help here. |
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
This PR is stale because it has been open 60 days with no activity. |
A stale bot? |
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Resolves: https://issues.redhat.com/browse/RHEL-38399 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]>
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399
This PR is stale because it has been open 60 days with no activity. |
This will be rebased once #5498 is merged in the main branch. |
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399 (cherry picked from commit 8800331)
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399 Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation (cherry picked from commit 8800331)
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399 Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation (cherry picked from commit 8800331)
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native Wayland client. This commit is a follow up on the work done by Neal Gompa [1], Martin Kolman and Ray Strode [2]. Credit goes to them for the code I copied and pasted. [1] rhinstaller#5401 [2] rhinstaller#5309 Co-authored-by: Neal Gompa <[email protected]> Co-authored-by: Martin Kolman <[email protected]> Co-authored-by: Ray Strode <[email protected]> Resolves: RHEL-38399 Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation (cherry picked from commit 8800331)
This PR is stale because it has been open 60 days with no activity. |
Waiting for #5829 to land before rebasing. |
This implements rudimentary support for running Anaconda on Wayland using the Weston compositor through XWayland. This support also includes simple auth-less VNC remote access, though authenticated VNC support requires extra effort since Weston's authenticated VNC support uses TLS certificates and we do not have a good way to plumb that through right now (more info in
weston-vnc(7)
).