{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":474711597,"defaultBranch":"main","name":"nushell","ownerLogin":"rgwood","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-03-27T17:36:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/26268125?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720230610.0","currentOid":""},"activityList":{"items":[{"before":"e82a94fadf6f2bd021c5e404d36b72b34dabdf39","after":"364bb0514efa444163300afe3c6d9dae49fad11c","ref":"refs/heads/explore-no-setup","pushedAt":"2024-07-06T04:14:50.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Merge branch 'main' into explore-no-setup","shortMessageHtmlLink":"Merge branch 'main' into explore-no-setup"}},{"before":"3fae77209a9fcfff0c9a4726ddd79432a62c3baa","after":"de2b752771f5d1d5672983a00a3676a246196295","ref":"refs/heads/main","pushedAt":"2024-07-06T01:50:32.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix variable completion sort order (#13306)\n\n<!--\r\nif this PR closes one or more issues, you can automatically link the PR\r\nwith\r\nthem by using one of the [*linking\r\nkeywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),\r\ne.g.\r\n- this PR should close #xxxx\r\n- fixes #xxxx\r\n\r\nyou can also mention related issues, PRs or discussions!\r\n-->\r\n\r\n# Description\r\n<!--\r\nThank you for improving Nushell. Please, check our [contributing\r\nguide](../CONTRIBUTING.md) and talk to the core team before making major\r\nchanges.\r\n\r\nDescription of your pull request goes here. **Provide examples and/or\r\nscreenshots** if your changes affect the user experience.\r\n-->\r\n\r\nMy last PR (https://github.com/nushell/nushell/pull/13242) made it so\r\nthat the last branch in the variable completer doesn't sort suggestions.\r\nSorry about that. This should fix it.\r\n\r\n# User-Facing Changes\r\n<!-- List of all changes that impact the user experience here. This\r\nhelps us keep track of breaking changes. -->\r\n\r\nVariables will now be sorted properly.\r\n\r\n# Tests + Formatting\r\n<!--\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to\r\ncheck that you're using the standard code style\r\n- `cargo test --workspace` to check that all tests pass (on Windows make\r\nsure to [enable developer\r\nmode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))\r\n- `cargo run -- -c \"use toolkit.nu; toolkit test stdlib\"` to run the\r\ntests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n-->\r\n\r\nAdded one test case to verify this won't happen again.\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->","shortMessageHtmlLink":"Fix variable completion sort order (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2393190548\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13306\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13306/hovercard\" href=\"https://github.com/nushell/nushell/pull/13306\">nushell#13306</a>)"}},{"before":null,"after":"e82a94fadf6f2bd021c5e404d36b72b34dabdf39","ref":"refs/heads/explore-no-setup","pushedAt":"2024-07-06T01:50:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"`explore`: Pass config to commands at creation time","shortMessageHtmlLink":"<code>explore</code>: Pass config to commands at creation time"}},{"before":"0024088052f39ab60625c83b5953ad88d1b1cb94","after":"59e0762ceecc1d665af456152578227517fc8d22","ref":"refs/heads/explore-no-drilldown","pushedAt":"2024-07-04T01:24:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Cleanup: renaming, remove unused comments","shortMessageHtmlLink":"Cleanup: renaming, remove unused comments"}},{"before":null,"after":"0024088052f39ab60625c83b5953ad88d1b1cb94","ref":"refs/heads/explore-no-drilldown","pushedAt":"2024-07-04T01:13:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Cleanup: renaming, remove obsolete comments","shortMessageHtmlLink":"Cleanup: renaming, remove obsolete comments"}},{"before":"3a6d8aac0bce6a70351fcfe860e0aa3694054a99","after":"3fae77209a9fcfff0c9a4726ddd79432a62c3baa","ref":"refs/heads/main","pushedAt":"2024-07-04T00:06:30.000Z","pushType":"push","commitsCount":67,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Revert \"Span ID Refactor (Step 2): Make Call SpanId-friendly (#13268)\" (#13292)\n\nThis reverts commit 0cfd5fbece6f25b54ab9dc417a9e06af9d83f282.\r\n\r\nThe original PR messed up syntax higlighting of aliases and causes\r\npanics of completion in the presence of alias.\r\n\r\n<!--\r\nif this PR closes one or more issues, you can automatically link the PR\r\nwith\r\nthem by using one of the [*linking\r\nkeywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),\r\ne.g.\r\n- this PR should close #xxxx\r\n- fixes #xxxx\r\n\r\nyou can also mention related issues, PRs or discussions!\r\n-->\r\n\r\n# Description\r\n<!--\r\nThank you for improving Nushell. Please, check our [contributing\r\nguide](../CONTRIBUTING.md) and talk to the core team before making major\r\nchanges.\r\n\r\nDescription of your pull request goes here. **Provide examples and/or\r\nscreenshots** if your changes affect the user experience.\r\n-->\r\n\r\n# User-Facing Changes\r\n<!-- List of all changes that impact the user experience here. This\r\nhelps us keep track of breaking changes. -->\r\n\r\n# Tests + Formatting\r\n<!--\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to\r\ncheck that you're using the standard code style\r\n- `cargo test --workspace` to check that all tests pass (on Windows make\r\nsure to [enable developer\r\nmode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))\r\n- `cargo run -- -c \"use toolkit.nu; toolkit test stdlib\"` to run the\r\ntests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n-->\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->","shortMessageHtmlLink":"Revert \"Span ID Refactor (Step 2): Make Call SpanId-friendly (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2381737559\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13268\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13268/hovercard\" href=\"https://github.com/nushell/nushell/pull/13268\">nushell…</a>"}},{"before":"b6767da195ef9b6648d1eeb2edab9552b676088f","after":"6948a37580106e21b702a9492c574d0c597343f2","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T23:59:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix 2 more","shortMessageHtmlLink":"Fix 2 more"}},{"before":"9b8cb4b3a3bef3c9509d451584cb3cfb011bc849","after":"b6767da195ef9b6648d1eeb2edab9552b676088f","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T23:57:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Get a few more tests passing","shortMessageHtmlLink":"Get a few more tests passing"}},{"before":"71133ab4976ec19e241385b822ad00543db9701a","after":"9b8cb4b3a3bef3c9509d451584cb3cfb011bc849","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T23:21:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix even more tests","shortMessageHtmlLink":"Fix even more tests"}},{"before":"d719f5347a0489590d78096edf32a46ee3a63493","after":"71133ab4976ec19e241385b822ad00543db9701a","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T23:14:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix more tests","shortMessageHtmlLink":"Fix more tests"}},{"before":"a90b1169a4e477885b6aa3695e782519ee3fefc6","after":"d719f5347a0489590d78096edf32a46ee3a63493","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T23:05:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix test","shortMessageHtmlLink":"Fix test"}},{"before":null,"after":"a90b1169a4e477885b6aa3695e782519ee3fefc6","ref":"refs/heads/Enable-header_on_separator-by-default","pushedAt":"2024-06-15T22:45:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Change header_on_separator default to true","shortMessageHtmlLink":"Change header_on_separator default to true"}},{"before":"323d5457f923c55d1b504ddca5614d283cd421af","after":"3a6d8aac0bce6a70351fcfe860e0aa3694054a99","ref":"refs/heads/main","pushedAt":"2024-06-15T18:05:31.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Return an empty list when no `std help --find` results are found (#13160)\n\n# Description\r\n\r\nFixes #13143 by returning an empty list when there are no results found\r\nby `std help --find/-f`\r\n\r\n# User-Facing Changes\r\n\r\nIn addition, prints a message to stderr.\r\n\r\n# Tests + Formatting\r\n\r\n- :green_circle: `toolkit fmt`\r\n- :green_circle: `toolkit clippy`\r\n- :green_circle: `toolkit test`\r\n- :green_circle: `toolkit test stdlib`\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->","shortMessageHtmlLink":"Return an empty list when no <code>std help --find</code> results are found (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2355004348\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13160\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13160/hovercard\" href=\"https://github.com/nushell/nushell/pull/13160\">nus…</a>"}},{"before":null,"after":"e4ecc9fcc617792e6cb9fb4f8e51a810c02ab98c","ref":"refs/heads/explore-config-in-constructors","pushedAt":"2024-06-13T03:19:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"WIP move config to ctors","shortMessageHtmlLink":"WIP move config to ctors"}},{"before":"75d5807dcd50876950204990dab4e1e3a326cbce","after":"323d5457f923c55d1b504ddca5614d283cd421af","ref":"refs/heads/main","pushedAt":"2024-06-13T02:33:50.000Z","pushType":"push","commitsCount":33,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Improve performance of `explore` - 1 (#13116)\n\nCould be improved further I guess; but not here;\r\n\r\nYou can test the speed differences using data from #13088\r\n\r\n```nu\r\nopen data.db | get profiles | explore\r\n```\r\n\r\naddress: #13062\r\n\r\n________\r\n\r\n1. Noticed that search does not work anymore (even on `main` branch).\r\n2. Not sure about resolved merged conflicts, seems fine, but maybe\r\nsomething was lost.\r\n\r\n---------\r\n\r\nCo-authored-by: Reilly Wood <reilly.wood@icloud.com>","shortMessageHtmlLink":"Improve performance of <code>explore</code> - 1 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2343169358\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13116\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13116/hovercard\" href=\"https://github.com/nushell/nushell/pull/13116\">nushell#13116</a>)"}},{"before":"b646da43057df4926bb7c3f997796782bbb30b1a","after":"280ddcfe1e7c256f1e336433299e577b0f3c8c6f","ref":"refs/heads/interrupt-csv","pushedAt":"2024-06-06T04:38:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Support ctrl-c cancellation in from csv/tsv","shortMessageHtmlLink":"Support ctrl-c cancellation in from csv/tsv"}},{"before":"c46e21a03c69b89df1143ea1bff6b6bd449bc6d8","after":"b646da43057df4926bb7c3f997796782bbb30b1a","ref":"refs/heads/interrupt-csv","pushedAt":"2024-06-06T04:37:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Support ctrl-c cancellation in from csv/tsv","shortMessageHtmlLink":"Support ctrl-c cancellation in from csv/tsv"}},{"before":null,"after":"c46e21a03c69b89df1143ea1bff6b6bd449bc6d8","ref":"refs/heads/interrupt-csv","pushedAt":"2024-06-06T04:23:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Support ctrl-c cancellation in from csv/tsv","shortMessageHtmlLink":"Support ctrl-c cancellation in from csv/tsv"}},{"before":"cf93f475e934e42852732a8ce1bfde66aa530567","after":"8e441f0b2df19771f3df15c6a10a710058b68671","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T03:05:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix up headers not showing up in :try","shortMessageHtmlLink":"Fix up headers not showing up in :try"}},{"before":"439130574365383e595616565c951020cea3954c","after":"cf93f475e934e42852732a8ce1bfde66aa530567","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T02:50:02.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Merge branch 'main' into overhaul_config","shortMessageHtmlLink":"Merge branch 'main' into overhaul_config"}},{"before":"96493b26d914d5ffce3d8a41d406abf417af5e05","after":"75d5807dcd50876950204990dab4e1e3a326cbce","ref":"refs/heads/main","pushedAt":"2024-06-06T02:49:39.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix `explore` panic on empty lists (#13074)\n\nThis fixes up a panic I accidentally introduced when refactoring the\r\ncursor code in `explore`: https://github.com/nushell/nushell/pull/12979\r\n\r\nUnder certain circumstances (running `:nu []`, opening `:try` with the\r\nhidden `try.reactive` setting enabled), `explore` would panic when\r\nhandling an empty list. To fix this for now I've removed the validation\r\nI added to the Cursor constructor in that PR.","shortMessageHtmlLink":"Fix <code>explore</code> panic on empty lists (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2337195569\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13074\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13074/hovercard\" href=\"https://github.com/nushell/nushell/pull/13074\">nushell#13074</a>)"}},{"before":"197eec39e5245018487669e9ea76aada48f2cb3b","after":"439130574365383e595616565c951020cea3954c","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T02:48:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"fmt, clippy","shortMessageHtmlLink":"fmt, clippy"}},{"before":null,"after":"673e1acc7e07ef6d838ac243d748af0e9b838193","ref":"refs/heads/fix-explore-panic","pushedAt":"2024-06-06T02:35:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Fix explore panic on empty lists","shortMessageHtmlLink":"Fix explore panic on empty lists"}},{"before":"fa3594bac82a41441569e7e1cf2e4e6e558f6934","after":"197eec39e5245018487669e9ea76aada48f2cb3b","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T02:24:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"get try mostly working","shortMessageHtmlLink":"get try mostly working"}},{"before":"684b259ee299d1840347f6f1e8c1e7ca0048de5e","after":"fa3594bac82a41441569e7e1cf2e4e6e558f6934","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T01:55:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"cleanup","shortMessageHtmlLink":"cleanup"}},{"before":"c93cca56d732e8638ac0771681e2dae092ddcd7c","after":"684b259ee299d1840347f6f1e8c1e7ca0048de5e","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T01:40:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"keep tweaking explore config","shortMessageHtmlLink":"keep tweaking explore config"}},{"before":null,"after":"c93cca56d732e8638ac0771681e2dae092ddcd7c","ref":"refs/heads/overhaul_config","pushedAt":"2024-06-06T00:55:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"WIP overhaul explore config","shortMessageHtmlLink":"WIP overhaul explore config"}},{"before":"6b2012bdfa3054aea87d4fd9133a8b825c7526b2","after":"96493b26d914d5ffce3d8a41d406abf417af5e05","ref":"refs/heads/main","pushedAt":"2024-06-05T23:09:07.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Make string related commands parse-time evaluatable (#13032)\n\n<!--\r\nif this PR closes one or more issues, you can automatically link the PR\r\nwith\r\nthem by using one of the [*linking\r\nkeywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),\r\ne.g.\r\n- this PR should close #xxxx\r\n- fixes #xxxx\r\n\r\nyou can also mention related issues, PRs or discussions!\r\n-->\r\n\r\nRelated meta-issue: #10239.\r\n\r\n# Description\r\n<!--\r\nThank you for improving Nushell. Please, check our [contributing\r\nguide](../CONTRIBUTING.md) and talk to the core team before making major\r\nchanges.\r\n\r\nDescription of your pull request goes here. **Provide examples and/or\r\nscreenshots** if your changes affect the user experience.\r\n-->\r\n\r\nThis PR will modify some `str`-related commands so that they can be\r\nevaluated at parse time.\r\n\r\nSee the following list for those implemented by this pr.\r\n\r\n# User-Facing Changes\r\n<!-- List of all changes that impact the user experience here. This\r\nhelps us keep track of breaking changes. -->\r\n\r\nAvailable now:\r\n- `str` subcommands\r\n  - `trim`\r\n  - `contains`\r\n  - `distance`\r\n  - `ends-with`\r\n  - `expand`\r\n  - `index-of`\r\n  - `join`\r\n  - `replace`\r\n  - `reverse`\r\n  - `starts-with`\r\n  - `stats`\r\n  - `substring`\r\n  - `capitalize`\r\n  - `downcase`\r\n  - `upcase`\r\n- `split` subcommands\r\n  - `chars`\r\n  - `column`\r\n  - `list`\r\n  - `row`\r\n  - `words`\r\n- `format` subcommands\r\n  - `date`\r\n  - `duration`\r\n  - `filesize`\r\n- string related commands\r\n  - `parse`\r\n  - `detect columns`\r\n  - `encode` & `decode`\r\n\r\n# Tests + Formatting\r\n<!--\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to\r\ncheck that you're using the standard code style\r\n- `cargo test --workspace` to check that all tests pass (on Windows make\r\nsure to [enable developer\r\nmode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))\r\n- `cargo run -- -c \"use toolkit.nu; toolkit test stdlib\"` to run the\r\ntests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n-->\r\n\r\nUnresolved questions:\r\n- [ ] Is there any routine of testing const expressions? I haven't found\r\nany yet.\r\n- [ ] Is const expressions required to behave just like there non-const\r\nversion, like what rust promises?\r\n\r\n# After Submitting\r\n<!-- If your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.\r\n-->\r\n\r\nUnresolved questions:\r\n- [ ] Do const commands need special marks in the docs?","shortMessageHtmlLink":"Make string related commands parse-time evaluatable (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2329497542\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13032\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13032/hovercard\" href=\"https://github.com/nushell/nushell/pull/13032\">nushell#13032</a>)"}},{"before":"f3cf693ec701ab3086f984a8aeadfc9b50fadd90","after":"6b2012bdfa3054aea87d4fd9133a8b825c7526b2","ref":"refs/heads/main","pushedAt":"2024-06-05T01:03:49.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Bump crate-ci/typos from 1.21.0 to 1.22.0\n\nBumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.21.0 to 1.22.0.\n- [Release notes](https://github.com/crate-ci/typos/releases)\n- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)\n- [Commits](https://github.com/crate-ci/typos/compare/v1.21.0...v1.22.0)\n\n---\nupdated-dependencies:\n- dependency-name: crate-ci/typos\n  dependency-type: direct:production\n  update-type: version-update:semver-minor\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump crate-ci/typos from 1.21.0 to 1.22.0"}},{"before":"f3991f2080284eadaec5a29b92def5bdf8d41248","after":"f3cf693ec701ab3086f984a8aeadfc9b50fadd90","ref":"refs/heads/main","pushedAt":"2024-06-02T14:39:08.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"rgwood","name":"Reilly Wood","path":"/rgwood","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26268125?s=80&v=4"},"commit":{"message":"Disallow more characters in arguments for internal `cmd` commands (#13009)\n\n# Description\r\nMakes `run-external` error if arguments to `cmd.exe` internal commands\r\ncontain newlines or a percent sign. This is because the percent sign can\r\nexpand environment variables, potentially? allowing command injection.\r\nNewlines I think will truncate the rest of the arguments and should\r\nprobably be disallowed to be safe.\r\n\r\n# After Submitting\r\n- If the user calls `cmd.exe` directly, then this bypasses our\r\nhandling/checking for internal `cmd` commands. Instead, we use the\r\nhandling from the Rust std lib which, in this case, does not do special\r\nhandling and is potentially unsafe. Then again, it could be the user's\r\nspecific intention to run `cmd` with whatever trusted input. The problem\r\nis that since we use the std lib handling, it assumes the exe uses the C\r\nruntime escaping rules and will perform some unwanted escaping. E.g., it\r\nwill add backslashes to the quotes in `cmd echo /c '\"\"'`.\r\n- If `cmd` is called indirectly via a `.bat` or `.cmd` file, then we use\r\nthe Rust std lib which has separate handling for bat files that should\r\nbe safe, but will reject some inputs.\r\n- ~~I'm not sure how we handle `PATHEXT`, that can also cause a file\r\nwithout an extension to be run as a bat file. If so, I don't know where\r\nthe handling, if any, is done for that.~~ It looks like we use the\r\n`which` crate to do the lookup using `PATHEXT`. Then, we pass the exe\r\npath from that to the Rust std lib `Command`, which should be safe\r\n(except for the first `cmd.exe` note).\r\n\r\nSo, in the future we need to unify and/or fix these different\r\nimplementations, including our own special handling for internal `cmd`\r\ncommands that this PR tries to fix.","shortMessageHtmlLink":"Disallow more characters in arguments for internal <code>cmd</code> commands (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2326279269\" data-permission-text=\"Title is private\" data-url=\"https://github.com/nushell/nushell/issues/13009\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/nushell/nushell/pull/13009/hovercard\" href=\"https://github.com/nushell/nushell/pull/13009\">nu…</a>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEeEDV-wA","startCursor":null,"endCursor":null}},"title":"Activity · rgwood/nushell"}