Remove assignments in conditionals

[sean-gilliam]

Assignments in conditionals while fun in the hackery sense tends to muddy logic clarity and tends to hide bugs.

if((victim = get_char_room(ch, arg2)) == NULL)

The above code is straight forward enough, however, if victim get used further down the method, it's hard to see were victim gets assigned.

We should consider removing assignments from conditionals.

[carewdavid]

I'll clean some of those up.

[BackstreetCultist]

I'm happy to take a look.

[rezalas]

If there are any you can find and resolve @BackstreetCultist feel free. Quite a few were cleaned in #37