Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using read -e PROMPT_RESPONSE would allow user to backspace if they make a typo #115

Closed
espoelstra opened this issue Nov 8, 2020 · 1 comment

Comments

@espoelstra
Copy link
Contributor

read PROMPT_RESPONSE

I noticed this was an issue in the official linux_recovery.sh from Google as well, where if you make a typo you can't backspace, and if the script doesn't re-prompt if the input was invalid for that particular prompt you end up having to Ctrl+C to abort and start over.

Since some of the parts of chrx are currently a little destructive like the early format of $(rootdisk -s -d)p7 before the user has accepted the risk of data loss if they'd already installed something via Chrx in the past, it would be good to avoid making them restart the script too many times, and keeping the destructive portions after the user has acknowledged their potential data loss.

@reynhout
Copy link
Owner

reynhout commented Nov 9, 2020

@espoelstra Great point! Will fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants