Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password not supporting some special characters. #41

Closed
0450 opened this issue Jul 9, 2019 · 4 comments
Closed

Password not supporting some special characters. #41

0450 opened this issue Jul 9, 2019 · 4 comments
Assignees
Labels

Comments

@0450
Copy link

0450 commented Jul 9, 2019

Most of my passwords with special characters always fails when trying to log in with SAM but its fine when i enter it manually. The passwords consists of !"#$%&'()*+,-./:;<=>?@[]^_`{|}~

@rex706
Copy link
Owner

rex706 commented Jul 9, 2019

@0450 It is most likely the - character that causes the problem. Since SAM uses the built in Steam login parameters to do the initial logging in, it probably interprets everything after that character as a launch parameter. Now that I have some more free time I am looking further into #35, which likely relates to this issue as well.

@rex706 rex706 self-assigned this Jul 9, 2019
@rex706 rex706 added the bug label Jul 9, 2019
@rex706 rex706 closed this as completed Jul 16, 2019
@rex706 rex706 reopened this Jul 16, 2019
@rex706
Copy link
Owner

rex706 commented Jul 16, 2019

Reopened this issue as some special characters like the hyphen - will not be usable in passwords currently with the -login parameter enabled. I am unsure if they can be escaped.

@rex706
Copy link
Owner

rex706 commented Jul 23, 2019

Update: Looks like this works in the limited tests I have run so far. Appending quotes around the password still logs in successfully through the -login argument. I may need to handle a few special cases with certain characters like quotes and percents as mentioned in the link but that shouldn't be too bad.

@rex706
Copy link
Owner

rex706 commented Jul 29, 2019

Update 2: As far as I can tell, after surrounding the password with quotes " and escaping quotes in the password with a backslash \ instead of additional quotes as the linked article in my previous update suggested, all other special characters seem to work fine using !"#$%&'()*+,-./:;<=>?@[]^_`{|}~ as a test password on a random test account. I probably just need to test passwords with multiple quotes in a row and things of that sort.

I should hopefully be able to release a new version with this fixed some time this week!

@rex706 rex706 closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants