Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentions of "URI" should be "URL" #80

Open
shazow opened this issue Sep 28, 2013 · 6 comments
Open

Mentions of "URI" should be "URL" #80

shazow opened this issue Sep 28, 2013 · 6 comments

Comments

@shazow
Copy link
Contributor

shazow commented Sep 28, 2013

The acronym uri is used all over the place in code and documentation, where it should be url. Also url is used in a bunch of places too, where it is already correct.

This is a semantic nitpick, and probably not worth breaking backwards compatibility over. But worth keeping in mind in case you ever end up doing a big refactor and see an opportunity to clean this up. :)

Feel free to close this bug if it doesn't make sense to pursue at this time.

@sigmavirus24
Copy link
Contributor

+1

@Lukasa
Copy link
Member

Lukasa commented Sep 29, 2013

This is a good idea! However, it will not be fixed in the next version of requests-oauthlib because I want 0.3.4 to make people's lives as easy as possible. =)

@ib-lundgren
Copy link
Member

Think the only place this would break would be the redirect_uri param and if we want to be careful we could always add redirect_url as a param and raise a deprecation warning when people pass in redirect_uri.

@Lukasa
Copy link
Member

Lukasa commented Oct 1, 2013

@ib-lundgren Not a bad idea: we should also raise a new issue to remind us to get rid of it eventually. =)

@KVGarg
Copy link

KVGarg commented Mar 4, 2019

@Lukasa @ib-lundgren As a newcomer, I would like to work upon this issue. Can I ?

@tomdottom
Copy link

a) I agree that a uniform use of one of uri & url is desirable; but
b) I would advocate uri over url

Why b)?

  • redirect_uri is commonly used. AWS, Google, Auth0 will report redirect_uri mismatch errors
    • it may be confusing to set redirect_url and get a redirect_uri error.
    • if we assume we should use redirect_uri here all others should follow uri convention
  • the underlying oauthlib uses the term uri
  • a url is a uri, but a uri is not a url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants