Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveralls decreased coverage threshold too thin #477

Closed
jtroussard opened this issue Jan 2, 2022 · 1 comment
Closed

coveralls decreased coverage threshold too thin #477

jtroussard opened this issue Jan 2, 2022 · 1 comment

Comments

@jtroussard
Copy link
Contributor

@JonathanHuot I believe you have permission to update coverall settings?

Looks like we should add a threshold value for decreased value to all for code reduction. Removing basically anything from the code base, seemingly even just comments (see #476 ) results in the remaining code to carry a slightly heavier weight. At least this is what I think is happening when coveralls runs it 3.8/3.9 coverage checks. It is failing simple, non-functional changes. Can we increase the decreased coverage threshold to something arbitrarily small? 0.1? Or perhaps there is a work around for this? Is there a coverall setting to ignore comments?

@jtroussard jtroussard changed the title coveralls decreased coverage threshold to thin coveralls decreased coverage threshold too thin Jan 2, 2022
@JonathanHuot
Copy link
Contributor

Coverage threshold has been set to 1% to avoid having floating or adding comment problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants