-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client_id
from session not used in fetch_token
#330
Comments
This is tied to a regression in oauthlib. I have a PR there and will create a new ticket or reopen this one when that is merged and I can write a PR for this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I got tripped up with the example doc on using fetch_token from the overview
https://requests-oauthlib.readthedocs.io/en/latest/
This doesn't seem to work against custom servers that require a client_id. The logic in
fetch_token
doesn't pull theclient_id
off the session, and consequently it's not sent upstream:https://github.com/requests/requests-oauthlib/blob/master/requests_oauthlib/oauth2_session.py#L200
it looks like we can just add 2 lines as a fallback condition to pull the client_id out:
The text was updated successfully, but these errors were encountered: