-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauthlib raises exception due to unquoted apostrophe or single quote #298
Comments
Hm. It seems like oauthlib and Requests are disagreeing on what URL spec to follow. I can be convinced that Requests is in the wrong here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to make a request that has a query parameter which contains apostrophes. oauthlib seems to only consider
=&;:%+~,*@!()/?
to be safe, but requests isn't encoding the apostrophe as %27, since it's passing!#$%&'()*+,/:;=?@[]~
as thesafe
list to urllib's quote here.I'm not really sure what the intentions of the various intermediate encoding steps are to fix the issue.
Expected Result
A successful GET request with a query parameter that includes apostrophes when using the requests_oauthlib plugin.
Actual Result
oauthlib raises an exception here due to the single quote not being encoded.
Reproduction Steps
System Information
The text was updated successfully, but these errors were encountered: