Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__version__ naming conflict #281

Closed
JherezTaylor opened this issue Jun 1, 2017 · 8 comments
Closed

__version__ naming conflict #281

JherezTaylor opened this issue Jun 1, 2017 · 8 comments

Comments

@JherezTaylor
Copy link

The version check in requests_oauthlib/__init__.py throws the following error under Python 3.5.3:
unorderable types: module() < str()

When I print the value of requests.__version__ it prints the path of the module requests.__version__ rather than the current package value 2.17.3

@Lukasa
Copy link
Member

Lukasa commented Jun 1, 2017

Ugh, this seems like a breaking change in Requests 2.17.3. Let's see if we can clean that up.

@JherezTaylor
Copy link
Author

Yea, I noticed it through a Twython import.

@Lukasa
Copy link
Member

Lukasa commented Jun 1, 2017

Hrm, hang on, what platform are you running on? I can't reproduce this problem with Requests directly in a shell.

@JherezTaylor
Copy link
Author

Ubuntu: 17.04
Python: 3.5.3
Jupyter Notebook: 4.4.0

Is there any other debug info I can provide?

@Lukasa
Copy link
Member

Lukasa commented Jun 1, 2017

Hrm, that's very odd. For this to be the case there would need to be some indeterminacy in the way things end up in the namespace. The way the Requests imports are written this should not be happening. Are you 100% confident that version 2.17.3 of Requests is what's running in your Jupyter kernel?

@JherezTaylor
Copy link
Author

Attaching the following screenshots and my stack trace
trace.txt
version_check1
version_check2

@JherezTaylor
Copy link
Author

JherezTaylor commented Jun 1, 2017

I should note that I can't seem to replicate the issue by creating a notebook that only includes the requests and requests_oauthlib import. I suspect that there might be some other funny business going on that doesn't involve requests_ouathlib. I'll just monkey patch it locally and go about my business.

@Lukasa
Copy link
Member

Lukasa commented Jun 1, 2017

Yeah, this seems to be a weirdness in your system somewhere. Sorry we can't be of more help!

@Lukasa Lukasa closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants