-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7.0 regression related to passing auth= parameter #254
Comments
Yeah, this code should probably be more defensive against users passing in |
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello :)
0.7.0 introduced this commit: 3348380 which introduces a problem if
kwargs
containsauth
.For example, the Asana python library does this:
response = getattr(self.session, method)(url, auth=self.auth, **request_options)
https://github.com/Asana/python-asana/blob/master/asana/client.py#L73
The stack trace this results in looks like this:
I'm assuming it is acceptable to pass an
auth
parameter. If not, I'll discuss this with the Asana people.Thanks <3
The text was updated successfully, but these errors were encountered: