Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New self-hosted config option platformOptions #29716

Open
RahulGautamSingh opened this issue Jun 17, 2024 · 3 comments
Open

New self-hosted config option platformOptions #29716

RahulGautamSingh opened this issue Jun 17, 2024 · 3 comments
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jun 17, 2024

Describe the proposed change(s).

To improve the organization and accessibility of platform-specific configuration options, combine them under a single config option named platformOptions.

Example:

{
  "platformOptions": {
    "gitlabMergeCheckAttempts": 3,
    "gitlabBranchStatusDelay": 4,
    "gitlabMergeRequestDelay": 100,
    "githubTokenWarn": false,
    "gitLabIgnoreApprovals": true,
    "bbUseDevelopmentBranch": true,
  }
}

Originally posted by @viceice in #29137 (comment)

@RahulGautamSingh RahulGautamSingh added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Jun 17, 2024
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Jun 17, 2024

Should azureWorkItemId, bbUseDefaultReviewers be included in this list too? These 2 are a repo config options, whereas all the others options that I included in the pr description are global only options.

@viceice
Copy link
Member

viceice commented Jun 17, 2024

Should azureWorkItemId be included in this list too? It is a repo config option currently whereas all the others are already global only options.

I'm not sure about that 🤔

@RahulGautamSingh

This comment was marked as outdated.

@RahulGautamSingh RahulGautamSingh added status:blocked Issue is blocked by another issue or external requirement and removed status:blocked Issue is blocked by another issue or external requirement labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants