Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo fetch for updating lock files #29620

Closed
rarkins opened this issue Jun 12, 2024 · 1 comment · Fixed by #30235
Closed

Use cargo fetch for updating lock files #29620

rarkins opened this issue Jun 12, 2024 · 1 comment · Fixed by #30235
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 12, 2024

Describe the proposed change(s).

Discussed in #29539

Per https://doc.rust-lang.org/cargo/commands/cargo-fetch.html, "cargo fetch" will update a lock file to match the Cargo.toml

This command would be better to use than our existing cargo update one. I think we can adopt this algorithm:

  • If there are any non-lockfile-only updates (i.e. Cargo.toml is updated) then we run a single cargo fetch
  • If there are any lockfile-only updates then we run cargo update targeting only those dependencies (similar to today)

We might need an additional cargo fetch after the cargo update commands, but we can leave that out for now if we're not sure.

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:cargo Cargo/Rust/crates.io labels Jun 12, 2024
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants