Missing Feature: helmfile oci:true is not read in case of using 3 dashes "---"

[PhilipAbed]

What would you like help with?

a case where oci:true in the helm file is not supported

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

github

Please tell us more about your question or problem

Having a helmfile like with separated repositories/ releases will not consider the oci repositories

{some configurations..}
---
repositories:
 - name: karpenter
    url: public.ecr.aws/karpenter
    oci: true
 {...some more repos}
---
releases:
  - name: karpenter
    chart: karpenter/karpenter
    version: 0.36.1
    {... some more releases}

The code expects repositories and releases to be in the same document.
but both are separated by --- which indicates the start of a new document.

see

renovate/lib/modules/manager/helmfile/extract.ts

Lines 117 to 126 in da33634

	const repository = doc.repositories?.find(
	(repo) => repo.name === repoName,
	);
	if (isOCIRegistry(dep.chart)) {
	res.datasource = DockerDatasource.id;
	res.packageName = repoName + '/' + depName;
	} else if (repository?.oci) {
	res.datasource = DockerDatasource.id;
	res.packageName = registryAliases[repoName] + '/' + depName;
	}

it is trying to find the same repository name in both releases and repositories in the same doc
but while debugging i can see they are separated into 2 docs.
first doc has repositories,
second doc has releases.

impact: This is causing karpetner dependency to use helm datasource instead of docker datasource even though it's set with oci:true

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

Good luck,

The Renovate team

[PhilipAbed]

i created a test in lib/modules/manager/helmfile/extract.spec.ts to reproduce the issue:

it('parses a chart with an oci repository and non-oci one with ---', async () => {
      const content = "repositories:\n" +
        "  - name: oci-repo\n" +
        "    url: ghcr.io/example/oci-repo\n" +
        "    oci: true\n" +
        "---\n" +
        "releases:\n" +
        "  - name: example\n" +
        "    version: 0.1.0\n" +
        "    chart: oci-repo/example";
      const fileName = 'helmfile.yaml';
      const result = await extractPackageFile(content, fileName, {
        registryAliases: {
          stable: 'https://charts.helm.sh/stable',
        },
      });
      expect(result).toMatchObject({
        datasource: 'helm',
        deps: [
          {
            currentValue: '0.1.0',
            depName: 'example',
            datasource: 'docker',
            packageName: 'ghcr.io/example/oci-repo/example',
          },
        ],
      });
    });

[viceice]

please paste the test failure?

[PhilipAbed]

[PhilipAbed]

Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 0

  Object {
    "datasource": "helm",
    "deps": Array [
      Object {
        "currentValue": "0.1.0",
-       "datasource": "docker",
        "depName": "example",
-       "packageName": "ghcr.io/example/oci-repo/example",
      },
    ],
  }
    at Object.<anonymous> (C:\github\renovate\lib\modules\manager\helmfile\extract.spec.ts:382:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

[viceice]

please use toEqual in test, so we see full diff in the error

[PhilipAbed]

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 3

  Object {
    "datasource": "helm",
    "deps": Array [
      Object {
        "currentValue": "0.1.0",
-       "datasource": "docker",
        "depName": "example",
-       "packageName": "ghcr.io/example/oci-repo/example",
+       "registryUrls": Array [
+         "ghcr.io/example/oci-repo",
+       ],
      },
    ],
  }
<Click to see difference>

    at Object.<anonymous> (C:\github\renovate\lib\modules\manager\helmfile\extract.spec.ts:382:22)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)