Jsonnet-bundler manager does not support SSH-based Git URLs #29782
Unanswered
Badbond
asked this question in
Request Help
Replies: 1 comment
-
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
GitHub. Version 37.183.1, but I had the same results on latest (37.413.2).
Please tell us more about your question or problem
When using SSH-based Git URLs inside
jsonnetfile.json
, thejsonnet-bundler
manager is not able to extract dependencies and logs an error while parsing thesource.git.remote
URL. It seems we parse the URL withnew URL(url)
under the hood, which throws exceptions for URLs in the format of:Looking at how it is done for the
git-submodules
manager, that does have this support, it would be better to reuse such logic and usegit-url-parse
'sgitUrlParse
method throughgit/url.ts
.I believe this issue predates many improvements that were done w.r.t. Git authentication support. Perhaps the improvements (such as #22061) pave the way to solve the issue here too. Note that this may resolve #14145 too, given I was able to get upgrades for our private repo when using an
https
URL, but the locking forjsonnetfile.lock.json
failed with the same issue as reported here.Example jsonnetfile.json
Logs (if relevant)
Logs
The Mend Renovate GitHub app has access to this reproduction repository mentioned below. It ran with completion, and logged the same:
Reproduction repository
https://github.com/Badbond/renovate-reproduction-case-jsonnet-ssh
Beta Was this translation helpful? Give feedback.
All reactions