package rule not applying registry url #29443
Replies: 2 comments 11 replies
-
|
You need to try registryAliases |
Beta Was this translation helpful? Give feedback.
-
|
environment variables are not substituted in regular config |
Beta Was this translation helpful? Give feedback.
-
|
Is that's the case, can you propose an alternative solution? |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, do not have any suggestions at this time |
Beta Was this translation helpful? Give feedback.
-
|
So I have 3 proposals to solve this issue, that would require changes to the Renovate source. The following is ordered by my personal opinion of most preferred solution to least preferred. Solution 1 customManagers: [
{
customType: "regex",
datasourceTemplate: "docker",
fileMatch: ["Dockerfile", "image.yaml"],
matchStrings: [
"\\$MY_REGISTRY\\\/(?<depName>.*?):(?<currentValue>.*?)\\s",
"\\${MY_REGISTRY}\\\/(?<depName>.*?):(?<currentValue>.*?)\\s"
]
}
],
packageRules: [
{
matchDatasources: ['docker'],
matchPackagePrefixes: ['ext'],
registryUrls: [
process.env.MY_IMAGE_REGISTRY
]
}
]Solution 2 registryAliases: {
"$MY_REGISTRY": process.env.MY_IMAGE_REGISTRY,
"${MY_REGISTRY}": process.env.MY_IMAGE_REGISTRY
},
customManagers: [
{
customType: "regex",
datasourceTemplate: "docker",
fileMatch: ["Dockerfile", "image.yaml"],
matchStrings: [
"(?<registryUrl>\\$MY_REGISTRY.*)\\\/(?<depName>.*?):(?<currentValue>.*?)\\s",
"(?<registryUrl>\\${MY_REGISTRY}.*)\\\/(?<depName>.*?):(?<currentValue>.*?)\\s"
]
}
]Solution 3 customManagers: [
{
customType: "regex",
datasourceTemplate: "docker",
fileMatch: ["Dockerfile", "image.yaml"],
matchStrings: [
"\\$MY_REGISTRY\\\/(?<depName>.*?):(?<currentValue>.*?)\\s",
"\\${MY_REGISTRY}\\\/(?<depName>.*?):(?<currentValue>.*?)\\s"
],
registryUrlTemplate: process.env.MY_IMAGE_REGISTRY
}
]@rarkins @viceice Let me know what you thing and if any of these would be possible to accomplish. |
Beta Was this translation helpful? Give feedback.
-
|
Please create a minimal reproduction. |
Beta Was this translation helpful? Give feedback.
-
|
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. To get started, please read our guide on creating a minimal reproduction. Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
Gitlab
Please tell us more about your question or problem
The following was tested with Renovate 35.350.1
We have a custom registry that proxies docker hub, like:
https://my.registry.com/ext.hub.docker.com/library/alpine:3.20.0. We then also use environment variables in our Dockerfiles and yamls to define the registry, like:${MY_REGISTRY}/ext.hub.docker.com/library/alpine:3.20.0.So what I'm trying to do is use a custom matcher to grab
ext.hub.docker.com/library/alpineas the package, then apply the registry when there is a package prefix ofext(see config below).My package rule seems to be ignored though, almost like it is automatically assuming the
ext.hub.docker.comis the registry and never checks the package rule. According to the logs (see below) it is correctly pulling thepackageNamebased on thematchStrings. It's just never being found with the package prefix matcher, thus never being assigned the correct registry.I've also tried
matchPackagePattern.Logs (if relevant)
Logs
{ "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "config": { "forkProcessing": "enabled", "autodiscover": true, "autodiscoverFilter": [ "mike/repo" ] }, "msg": "CLI config", "time": "2024-06-05T04:46:33.817Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "config": { "hostRules": [ { "hostType": "github", "matchHost": "github.com", "token": "***********" } ], "repositoryCache": "enabled", "baseDir": "/builds/tools/renovate/renovate", "logFile": "renovate-log.json", "logFileLevel": "debug", "onboarding": false, "requireConfig": "required", "optimizeForDisabled": true, "platform": "gitlab", "endpoint": "https://my.gitlab.com/api/v4", "token": "***********", "ignorePrAuthor": true }, "msg": "Env config", "time": "2024-06-05T04:46:33.817Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "config": { "extends": [ "config:recommended" ], "prHourlyLimit": 0, "printConfig": false, "rebaseWhen": "auto", "autodiscoverFilter": [ "mike/repo" ], "branchPrefix": "renovate-", "onboardingBranch": "renovate-configure", "rangeStrategy": "bump", "allowedPostUpgradeCommands": [ ".*renovate.sh" ], "packageRules": [ { "matchDatasources": [ "docker" ], "matchPackagePrefix": [ "ext" ], "registryUrls": [ "my.registry.com" ] } ], "repositoryCache": "enabled", "baseDir": "/builds/tools/renovate/renovate", "logFile": "renovate-log.json", "logFileLevel": "debug", "onboarding": false, "requireConfig": "required", "optimizeForDisabled": true, "platform": "gitlab", "endpoint": "https://my.gitlab.com/api/v4", "token": "***********", "ignorePrAuthor": true, "forkProcessing": "enabled", "autodiscover": true }, "msg": "Combined config", "time": "2024-06-05T04:46:33.818Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "fileName": "renovate.json", "config": { "extends": [ "config:base" ], "gitLabAutomerge": false, "gitLabIgnoreApprovals": true, "enabledManagers": [ "regex" ], "customManagers": [ { "customType": "regex", "datasourceTemplate": "docker", "fileMatch": [ "Dockerfile", "global-images.yaml" ], "matchStrings": [ "\\$MY_REGISTRY\\/(?<depName>.*?):(?<currentValue>.*?)\\s", "\\${MY_REGISTRY}\\/(?<depName>.*?):(?<currentValue>.*?)\\s" ] } ], "packageRules": [ { "enabled": true, "matchManagers": [ "regex" ], "matchFileNames": [ "global-images.yaml" ], "groupName": "global images", "groupSlug": "global-images" }, { "enabled": true, "matchManagers": [ "regex" ], "matchPackagePatterns": [ "eclipse-temurin$" ], "groupName": "eclipse temurin images", "groupSlug": "eclipse-temurin-images", "versioning": "regex:^(?<major>\\d+)(\\.(?<minor>\\d+))?(\\.(?<patch>\\d+))?([\\._](?<build>[\\d_]+))?(-(?<compatibility>.*))?$" }, { "enabled": true, "matchManagers": [ "regex" ], "matchPackagePatterns": [ "python$" ], "groupName": "python images", "groupSlug": "python-images" }, { "enabled": true, "matchManagers": [ "regex" ], "matchPackagePatterns": [ "node$" ], "groupName": "node images", "groupSlug": "node-images" }, { "enabled": true, "matchManagers": [ "regex" ], "matchPackagePatterns": [ "alpine$" ], "groupName": "alpine images", "groupSlug": "alpine-images" } ] }, "msg": "Repository config", "time": "2024-06-05T04:46:46.583Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "msg": "Using file match: Dockerfile for manager regex", "time": "2024-06-05T04:47:30.096Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "msg": "Using file match: global-images.yaml for manager regex", "time": "2024-06-05T04:47:30.120Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "msg": "Matched 479 file(s) for manager regex: ...", "time": "2024-06-05T04:47:30.147Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 30, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "baseBranch": "develop", "stats": { "managers": { "regex": { "fileCount": 242, "depCount": 400 } }, "total": { "fileCount": 583, "depCount": 1269 } }, "msg": "Dependency extraction complete", "time": "2024-06-05T04:47:39.809Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "msg": "GET https://ext.hub.docker.com/v2/library/alpine/tags/list?n=10000 = (code=ECONNRESET, statusCode=-1 retryCount=2, duration=829)", "time": "2024-06-05T04:47:44.717Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 40, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "registryHost": "https://ext.hub.docker.com", "dockerRepository": "library/alpine", "err": { "name": "RequestError", "code": "ECONNRESET", "timings": { "start": 1717562863888, "socket": 1717562864223, "lookup": 1717562864223, "connect": 1717562864223, "error": 1717562864717, "phases": { "wait": 335, "dns": 0, "tcp": 0, "total": 829 } }, "message": "Client network socket disconnected before secure TLS connection was established", "stack": "RequestError: Client network socket disconnected before secure TLS connection was established\n at ClientRequest.<anonymous> (/usr/local/renovate/node_modules/.pnpm/[email protected]/node_modules/got/dist/source/core/index.js:970:111)\n at Object.onceWrapper (node:events:632:26)\n at ClientRequest.emit (node:events:529:35)\n at ClientRequest.emit (node:domain:489:12)\n at ClientRequest.origin.emit (/usr/local/renovate/node_modules/.pnpm/@[email protected]/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)\n at TLSSocket.socketErrorListener (node:_http_client:501:9)\n at TLSSocket.emit (node:events:529:35)\n at TLSSocket.emit (node:domain:489:12)\n at emitErrorNT (node:internal/streams/destroy:151:8)\n at emitErrorCloseNT (node:internal/streams/destroy:116:3)\n at connResetException (node:internal/errors:720:14)\n at TLSSocket.onConnectEnd (node:_tls_wrap:1714:19)\n at TLSSocket.emit (node:events:529:35)\n at TLSSocket.emit (node:domain:489:12)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at processTicksAndRejections (node:internal/process/task_queues:82:21)", "options": { "headers": { "user-agent": "RenovateBot/37.313.1 (https://github.com/renovatebot/renovate)", "accept": "application/json", "accept-encoding": "gzip, deflate, br" }, "url": "https://ext.hub.docker.com/v2/library/alpine/tags/list?n=10000", "hostType": "docker", "username": "", "password": "", "method": "GET", "http2": false } }, "msg": "Error obtaining docker token", "time": "2024-06-05T04:47:44.717Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "baseBranch": "develop", "config": { "regex": [ { "deps": [ { "depName": "ext.hub.docker.com/library/alpine", "currentValue": "3.20.0", "datasource": "docker", "replaceString": "${MY_REGISTRY}/ext.hub.docker.com/library/alpine:3.20.0\n", "updates": [], "packageName": "ext.hub.docker.com/library/alpine", "versioning": "docker", "warnings": [ { "topic": "ext.hub.docker.com/library/alpine", "message": "Failed to look up docker package ext.hub.docker.com/library/alpine" } ] } ], "matchStrings": [ "\\$MY_REGISTRY\\/(?<depName>.*?):(?<currentValue>.*?)\\s", "\\${MY_REGISTRY}\\/(?<depName>.*?):(?<currentValue>.*?)\\s" ], "datasourceTemplate": "docker", "packageFile": "project/Dockerfile" } ] }, "msg": "packageFiles with updates", "time": "2024-06-05T04:49:46.291Z", "v": 0 } { "name": "renovate", "hostname": "runner-5snjhe2-project-77108-concurrent-0", "pid": 20, "level": 20, "logContext": "XPtGIWZZcY9ZH1nXEG0SF", "repository": "mike/repo", "urls": { "https://ext.hub.docker.com/v2/library/alpine/tags/list": { "GET": { "-1": 1 } } }, "hosts": { "ext.hub.docker.com": { "count": 13, "reqAvgMs": 495, "reqMedianMs": 433, "reqMaxMs": 892, "queueAvgMs": 0, "queueMedianMs": 0, "queueMaxMs": 1 } }, "requests": 6474, "msg": "HTTP statistics", "time": "2024-06-05T04:51:35.302Z", "v": 0 }Beta Was this translation helpful? Give feedback.
All reactions