goModTidy not running in PRs using extended config

[shawon-crosen]

What would you like help with?

I would like help with my configuration

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

We have a parent config that we extend in a number of other repositories. Our repositories with go dependencies are not having go mod tidy run in renovate PRs even though we have that set in the postUpdateOptions.

Here is the parent config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "schedule": [
    "on sunday"
  ],
  "extends": [
    "local>circleci/renovate-config"
  ],
  "packageRules": [
    {
      "matchManagers": ["poetry"],
      "groupName": "poetry dependencies",
      "groupSlug": "poetry"
    },
    {
      "matchManagers": ["npm"],
      "groupName": "Node.js packages"
    },
    {
      "matchPackageNames": [
        "go",
        "docker.io/library/golang",
        "cimg/go"
      ],
      "matchManagers": ["gomod"],
      "groupName": "Go updates",
      "postUpdateOptions": [
        "gomodTidy",
        "gomodUpdateImportPaths"
      ]
    },
    {
      "matchManagers": ["dockerfile", "docker-compose"],
      "groupName": "Docker updates"
    },
    {
      "matchManagers": ["terraform"],
      "groupName": "Terraform updates"
    },
    {
      "matchManagers": ["circleci"],
      "groupName": "CircleCI updates"
    }
  ]
}

Here is an example of a repo using that parent config:

{
  // our base renovate config can be found here 
  // https://github.com/circleci/data-platform-monorepo/blob/master/renovate.json
  
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "local>circleci/data-platform-monorepo:renovate.json"
  ]
}

Logs (if relevant)

Logs

Here is an example of the logs for one of the packages. You can see it doesn't even attempt to run go mod tidy.

DEBUG: Resolved stable matching version (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "toolName": "golang"
  "constraint": "^1.21"
  "resolvedVersion": "1.22.3"
}

DEBUG: Executing command (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "command": "install-tool golang 1.22.3"
}

DEBUG: exec completed (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "durationMs": 7580
  "stdout": "[19:44:33.795] INFO (51): Installing tool [email protected]...\ninstalling v2 tool golang v1.22.3\nlinking tool golang v1.22.3\ngo version go1.22.3 linux/amd64\nGO111MODULE=''\nGOARCH='amd64'\nGOBIN=''\nGOCACHE='/home/ubuntu/.cache/go-build'\nGOENV='/home/ubuntu/.config/go/env'\nGOEXE=''\nGOEXPERIMENT=''\nGOFLAGS='-modcacherw'\nGOHOSTARCH='amd64'\nGOHOSTOS='linux'\nGOINSECURE=''\nGOMODCACHE='/go/pkg/mod'\nGONOPROXY=''\nGONOSUMDB=''\nGOOS='linux'\nGOPATH='/go'\nGOPRIVATE=''\nGOPROXY='https://proxy.golang.org,direct'\nGOROOT='/opt/containerbase/tools/golang/1.22.3'\nGOSUMDB='off'\nGOTMPDIR=''\nGOTOOLCHAIN='auto'\nGOTOOLDIR='/opt/containerbase/tools/golang/1.22.3/pkg/tool/linux_amd64'\nGOVCS=''\nGOVERSION='go1.22.3'\nGCCGO='gccgo'\nGOAMD64='v1'\nAR='ar'\nCC='gcc'\nCXX='g++'\nCGO_ENABLED='0'\nGOMOD='/tmp/renovate/repos/github/circleci/event-forwarder/go.mod'\nGOWORK=''\nCGO_CFLAGS='-O2 -g'\nCGO_CPPFLAGS=''\nCGO_CXXFLAGS='-O2 -g'\nCGO_FFLAGS='-O2 -g'\nCGO_LDFLAGS='-O2 -g'\nPKG_CONFIG='pkg-config'\nGOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2488555645=/tmp/go-build -gno-record-gcc-switches'\n[19:44:40.186] INFO (51): Installed tool golang in 6.3s.\n"
  "stderr": ""
}

DEBUG: Executing command (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "command": "go get -d -t ./..."
}

DEBUG: exec completed (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "durationMs": 12589
  "stdout": ""
  "stderr": "go: downloading github.com/circleci/backplane-go v0.36.10051\ngo: downloading github.com/aws/aws-sdk-go-v2 v1.27.0\ngo: downloading github.com/aws/aws-sdk-go-v2/config v1.27.16\ngo: downloading github.com/aws/aws-sdk-go-v2/service/firehose v1.28.10\ngo: downloading google.golang.org/protobuf v1.34.1\ngo: downloading github.com/circleci/events/pb v0.1.1336\ngo: downloading github.com/brianvoe/gofakeit/v6 v6.24.0\ngo: downloading github.com/rabbitmq/amqp091-go v1.10.0\ngo: downloading golang.org/x/sync v0.7.0\ngo: downloading github.com/aws/smithy-go v1.20.2\ngo: downloading github.com/aws/aws-sdk-go-v2/credentials v1.17.16\ngo: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.3\ngo: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.8.0\ngo: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.20.9\ngo: downloading github.com/aws/aws-sdk-go-v2/service/ssooidc v1.24.3\ngo: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.28.10\ngo: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.7\ngo: downloading github.com/sethvargo/go-envconfig v0.9.0\ngo: downloading github.com/go-playground/validator/v10 v10.20.0\ngo: downloading go.opentelemetry.io/otel v1.26.0\ngo: downloading github.com/makasim/amqpextra v1.2.1\ngo: downloading github.com/hellofresh/health-go/v5 v5.5.3\ngo: downloading github.com/hashicorp/vault/api v1.13.0\ngo: downloading github.com/hashicorp/vault/api/auth/kubernetes v0.6.0\ngo: downloading github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.2\ngo: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.9\ngo: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.7\ngo: downloading github.com/google/uuid v1.6.0\ngo: downloading go.opentelemetry.io/otel/trace v1.26.0\ngo: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.26.0\ngo: downloading go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.26.0\ngo: downloading go.opentelemetry.io/otel/sdk v1.26.0\ngo: downloading github.com/rollbar/rollbar-go v1.4.5\ngo: downloading github.com/DataDog/datadog-go/v5 v5.5.0\ngo: downloading github.com/gabriel-vasile/mimetype v1.4.3\ngo: downloading github.com/go-playground/universal-translator v0.18.1\ngo: downloading github.com/leodido/go-urn v1.4.0\ngo: downloading golang.org/x/crypto v0.22.0\ngo: downloading golang.org/x/text v0.14.0\ngo: downloading github.com/jolestar/go-commons-pool/v2 v2.1.2\ngo: downloading github.com/go-logr/logr v1.4.1\ngo: downloading go.opentelemetry.io/otel/metric v1.26.0\ngo: downloading github.com/cenkalti/backoff/v3 v3.2.2\ngo: downloading github.com/go-jose/go-jose/v4 v4.0.1\ngo: downloading github.com/hashicorp/errwrap v1.1.0\ngo: downloading github.com/hashicorp/go-cleanhttp v0.5.2\ngo: downloading github.com/hashicorp/go-multierror v1.1.1\ngo: downloading github.com/hashicorp/go-retryablehttp v0.7.5\ngo: downloading github.com/hashicorp/go-rootcerts v1.0.2\ngo: downloading github.com/hashicorp/go-secure-stdlib/parseutil v0.1.7\ngo: downloading github.com/hashicorp/go-secure-stdlib/strutil v0.1.2\ngo: downloading github.com/hashicorp/hcl v1.0.1-vault-5\ngo: downloading github.com/mitchellh/mapstructure v1.5.0\ngo: downloading golang.org/x/net v0.24.0\ngo: downloading golang.org/x/time v0.3.0\ngo: downloading go.opentelemetry.io/proto/otlp v1.2.0\ngo: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240401170217-c3f982113cda\ngo: downloading google.golang.org/grpc v1.63.2\ngo: downloading golang.org/x/sys v0.19.0\ngo: downloading github.com/Microsoft/go-winio v0.6.1\ngo: downloading github.com/go-playground/locales v0.14.1\ngo: downloading github.com/go-logr/stdr v1.2.2\ngo: downloading github.com/hashicorp/go-sockaddr v1.0.5\ngo: downloading github.com/mitchellh/go-homedir v1.1.0\ngo: downloading github.com/ryanuber/go-glob v1.0.0\ngo: downloading github.com/cenkalti/backoff/v4 v4.3.0\ngo: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.1\ngo: downloading golang.org/x/tools v0.14.0\ngo: downloading google.golang.org/genproto/googleapis/api v0.0.0-20240227224415-6ceb2ff114de\ngo: downloading golang.org/x/mod v0.13.0\ngo: upgraded github.com/aws/aws-sdk-go-v2/credentials v1.17.15 => v1.17.16\ngo: upgraded github.com/aws/aws-sdk-go-v2/service/sso v1.20.8 => v1.20.9\ngo: upgraded github.com/aws/aws-sdk-go-v2/service/ssooidc v1.24.2 => v1.24.3\ngo: upgraded github.com/aws/aws-sdk-go-v2/service/sts v1.28.9 => v1.28.10\n"
}

DEBUG: Returning updated go.sum (branch="renovate/aws-sdk-go-v2-monorepo")
DEBUG: Found updated go.mod after go.sum update (branch="renovate/aws-sdk-go-v2-monorepo")
DEBUG: Updated 1 package files (branch="renovate/aws-sdk-go-v2-monorepo")
DEBUG: Updated 2 lock files (branch="renovate/aws-sdk-go-v2-monorepo")
{
  "updatedArtifacts": [
    "go.sum",
    "go.mod"
  ]
}

The config seems to be working with grouping properly, it just isn't running the tidy step at all.

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team

[rarkins]

You've set the options only for itself and not for other package names?

[shawon-crosen]

Sorry I don't understand what that means exactly. I thought that setting the option for the package rule would run mod tidy for all packages found for that rule?

      "matchPackageNames": [
        "go",
        "docker.io/library/golang",
        "cimg/go"
      ],
      "matchManagers": ["gomod"],
      "groupName": "Go updates",
      "postUpdateOptions": [
        "gomodTidy",
        "gomodUpdateImportPaths"
      ]
    },

Do we need to remove the matchPackageNames option and only use matchManagers to apply it to all the packages picked up by the manager?

[rarkins]

Yes, your matchPackageNames looks like a mistake here