Updating git dependencies in poetry does not work when dependent repositories are in github enterprise

[jitheshdb]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

37.140.6

If you're self-hosting Renovate, select which platform you are using.

GitHub Enterprise Server

What is your question?

From the release notes, I have found the Renovate started supporting git dependencies in poetry. There are two ways in which we configure git dependencies in poetry

1. Dependency pointing to a particular commit
   my-tools = {git = "https://github-partner.xyz.com/jithesh/my-tools", rev = "8b8f40d8c4d89e04fc609d87d4ae60600b5f5a2d"}
2. Dependency pointing to a particular tag in the repo
   my-tools = {git = "https://github-partner.xyz.com/jithesh/my-tools", tag="1.5.0"}

I have observed that, renovate can update the dependency in the option 1 above. Means, it can update when I use 'rev' in the configuration.
But, when 'tag' is used as in the second option, Renovate skips this dependency with following message in the log

{
                 "datasource": "git-refs",
                 "currentValue": "1.5.0",
                 "packageName": "https://github-partner.xyz.com/jithesh/my-tools",
                 "skipReason": "git-dependency",
                 "depName": "my-tools",
                 "depType": "dependencies",
                 "updates": []
}

I have looked at the Renovate source code and in the poetry manager code, I found that it checks if the repo url contains 'github.com', only when 'tag' is handled. Since github enterprise repo url does not contain 'github.com', it skips the dependency. On the other hand, when 'rev' is used, the repo url is not checked and hence it works.

Is this a bug or intentionally did it that way?

Logs (if relevant)

Logs

Copy/paste the relevant log(s) here, between the starting and ending backticks

[viceice]

seems like a bug

[jitheshdb]

Thank you for the response. How can I raise this bug? Shall I just change the category of this thread to 'Report a problem'?

[rarkins]

Create a reproduction in a GitHub.con repo. Likely doesn't need a lock file or even valid hosts in order to reduce

[jitheshdb]

Sure. But the issue is with dependent repositories in github enterprise. The bug cannot be reproduced in github.com. If the reproduction repo is only to see the configuration files, I can create one.

[rarkins]

The bug appears to be that skipReason is set unnecessarily. If so then it can be reproduced on github.com, even using --dry-run=extract. It is not necessary to have a full end to end working example

[jitheshdb]

I have created a minimal reproduction repo. Is there anything else I need to do?

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[jitheshdb]

@viceice @rarkins I have created a minimal reproduction repository here : https://github.com/jitheshdb/PoetryGHEDependencySample

The details are given in its readme file.

Thank you

[benedikt-bartscher]

@jitheshdb Thanks for the reproduction repo! I am also wondering if there is any reason for the url check against github.com if it's a git dependency. This prevents renovate from updating poetry deps on gitlab aswell :/

[rarkins]

Converted to issue: #27660