In a monorepo, one dependency should hit multiple packageRules, but it doesn't

[pbabbicola]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

Was this something which used to work for you, and then stopped?

I never saw this working

Wanted end result.

I am working in a monorepo with several go modules in a go workspace. When a dependency is updated, it will find all the go.mods that use it, and apply all the package rules that they require (in particular, additionalReviewers). So for example if I have additionalReviewers from team A in one packageRule and team B in another packageRule, and the dependency affects both, then both teams should be tagged.

What you tried so far.

So far my configuration looks like this:

...
"packageRules": [
    { // services from team A
      "matchPaths": [
        "service1/**",
        "service2/**",
        "service3/**",
      ],
      "matchManagers": [
        "gomod",
      ],
      "additionalReviewers": ["team:team-a"],
    },
    {  // services from team B
      "matchPaths": [
        "service4/**",
        "service5/**",
        "service6/**",
      ],
      "matchManagers": [
        "gomod",
      ],
      "additionalReviewers": ["team:team-b"],
    },
...

If we have a common dependency (let's say, google.golang.org/grpc), it will tag only one of the teams, but update both. I would like it to tag both teams as reviewers.

Relevant debug logs

No response

[github-actions[bot]]

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[rarkins]

I'd need a reproduction in order to debug. Additional reviewers field is meant to be mergeable

[pbabbicola]

I'd need a reproduction in order to debug. Additional reviewers field is meant to be mergeable

Thanks! I'll do this as soon as I can.

[pbabbicola]

@rarkins here is a minimal reproduction: pbabbicola/minima-renovate-reproduction#2

[pbabbicola]

@rarkins today all the PR requests had multiple reviewers correctly assigned (I didn't check for all of them but at least there were many from more than one team), should I consider this fixed? Do you still need the reproduction?

[rarkins]

I think it was fixed by @zharinov

[zharinov]

Yes, but it's minimal fix related only to additionalReviewers. Feel free to suggest another fields that should follow the same logic.

[pbabbicola]

I'm guessing anything that appends - like additionalBranchPrefix or addLabels.

[rarkins]

Anything which is an array and has mergeable=true