Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stitchFramesToVideo documentation seems to be stale #3893

Closed
Mike-Dax opened this issue May 19, 2024 · 1 comment · Fixed by #4133
Closed

stitchFramesToVideo documentation seems to be stale #3893

Mike-Dax opened this issue May 19, 2024 · 1 comment · Fixed by #4133
Labels
bug Something isn't working

Comments

@Mike-Dax
Copy link

Bug Report 🐛

The argument documentation for stitchFramesToVideo seems to be stale. It no longer takes a dir argument.

assetsInfo appears to contain more than just the audio mix, such as the pattern for file matching for passing to ffmpeg.

It would be nice for that pattern to be passed from renderFrames then separately passable into stitchFramesToVideo, since assetsInfo is considered an opaque internal type to Remotion that might break on version upgrades.
@Mike-Dax Mike-Dax added the bug Something isn't working label May 19, 2024
@JonnyBurger
Copy link
Member

Thanks for filing this!

@JonnyBurger JonnyBurger linked a pull request Jul 30, 2024 that will close this issue
@remotion/renderer: Update stitchFramesToVideo signature and docs #4133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@remotion/renderer: Update stitchFramesToVideo signature and docs remotion-dev/remotion
2 participants
@JonnyBurger @Mike-Dax