flat is not function when run i android 9

[shaodahong]

Reproduction

official demo

System Info

android 9

Used Package Manager

npm

Expected Behavior

android 9 work fine

Actual Behavior

break in android 9

[shaodahong]

and when i use @vitejs/plugin-legacy solve it, still not work

[brophdawg11]

Please provide the specific error you're receiving and ideally a minimal reproduction

[shaodahong]

Please provide the specific error you're receiving and ideally a minimal reproduction

p.concat(...).map(...).flat is not a function Error message with Sentry , and when i search have many flat use

[brophdawg11]

Ah ok - you can fix this by polyfilling APIs you need - Array.prototype.flat has very good browser support so it's not something Remix would polyfill internally. I would recommend checking out core-js or https://polyfill.io/

⚠️ Scratch that - DO NOT USE polyfil.io - https://sansec.io/research/polyfill-supply-chain-attack

[shaodahong]

Ah ok - you can fix this by polyfilling APIs you need - Array.prototype.flat has very good browser support so it's not something Remix would polyfill internally. I would recommend checking out core-js or https://polyfill.io/

Thanks, finally, I manually imported core-js to solve it, but the problem is that each change becomes dangerous. Does remix plan to support the @vitejs/plugin-legacy plugin?

[brophdawg11]

I'm not familiar with that plugin - can you not just add it to your vite config alongside the Remix plugin? If that doesn't work, I would open a new issue with a reproduction of that plugins incompatibility.

[brophdawg11]

⚠️ Scratch that - DO NOT USE polyfil.io - https://sansec.io/research/polyfill-supply-chain-attack

[shaodahong]

I'm not familiar with that plugin - can you not just add it to your vite config alongside the Remix plugin? If that doesn't work, I would open a new issue with a reproduction of that plugins incompatibility.

Yes, it doesn't work at all, and I create mini demo, you can see generate a polyfill asset when build, but html and manifest not include that

https://stackblitz.com/edit/remix-run-remix-ntmn6p?file=vite.config.ts

and thanks again for the heads up about the polyfill.io risk

[shaodahong]

I'm not familiar with that plugin - can you not just add it to your vite config alongside the Remix plugin? If that doesn't work, I would open a new issue with a reproduction of that plugins incompatibility.

I spent a bit of time looking at @vitejs/plugin-legacy and it seems to do post-processing on the build target's html to make it compatible with older browsers, if there were a way to get that working it seems like the browser compatibility of remix would be incredibly strong

https://github.com/vitejs/vite/blob/3af02bde7e7f26889d5c0eb300219c43ed1293ad/packages/plugin-legacy/src/index.ts#L560