Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Support for react-devtools #994

Merged
merged 11 commits into from
Jun 15, 2020
Merged

Support for react-devtools #994

merged 11 commits into from
Jun 15, 2020

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented May 23, 2020

@vercel
Copy link

vercel bot commented May 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/onxofjdcj
✅ Preview: https://remax-git-react-devtools.remaxjs.vercel.app

@yesmeck yesmeck marked this pull request as draft May 23, 2020 20:07
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2dea615:

Sandbox Source
mystifying-varahamihira-evp7s Configuration

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #994 into master will decrease coverage by 0.60%.
The diff coverage is 67.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   95.71%   95.11%   -0.61%     
==========================================
  Files         332      333       +1     
  Lines        3597     3644      +47     
  Branches      509      522      +13     
==========================================
+ Hits         3443     3466      +23     
- Misses        153      177      +24     
  Partials        1        1              
Impacted Files Coverage Δ
packages/remax-cli/src/build/utils/env.ts 100.00% <ø> (ø)
packages/remax-shared/src/formatDisplayName.ts 16.66% <16.66%> (ø)
packages/remax-runtime/src/render.ts 86.66% <50.00%> (-5.65%) ⬇️
packages/remax-one/src/createHostComponent.ts 91.04% <66.66%> (-1.15%) ⬇️
packages/remax-shared/src/createHostComponent.ts 90.90% <66.66%> (-9.10%) ⬇️
packages/remax-cli/src/build/babel/app.ts 97.05% <75.00%> (-2.95%) ⬇️
packages/remax-cli/src/build/index.ts 67.85% <83.33%> (+2.63%) ⬆️
packages/remax-cli/src/build/babel/page.ts 93.93% <85.71%> (-2.73%) ⬇️
packages/remax-cli/src/API.ts 100.00% <100.00%> (ø)
packages/remax-runtime/src/PageInstanceContext.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fed4d...2dea615. Read the comment docs.

@yesmeck yesmeck marked this pull request as ready for review June 12, 2020 18:37
@vercel vercel bot temporarily deployed to Preview June 12, 2020 19:25 Inactive