Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

perf(remax): 避免更新没有变化的属性 #989

Merged
merged 22 commits into from
Jun 1, 2020
Merged

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented May 23, 2020

No description provided.

@Darmody Darmody requested a review from yesmeck May 23, 2020 04:24
@vercel
Copy link

vercel bot commented May 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/5zcvhnpjx
✅ Preview: https://remax-git-refactor-update-props.remaxjs.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 23, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c87f6c:

Sandbox Source
mystifying-mountain-18qg1 Configuration

@Darmody
Copy link
Contributor Author

Darmody commented May 23, 2020

这个 PR 应该还会解决微信端的一系列问题:

例如: #987

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #989 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   95.56%   95.61%   +0.04%     
==========================================
  Files         331      329       -2     
  Lines        3542     3533       -9     
  Branches      505      512       +7     
==========================================
- Hits         3385     3378       -7     
+ Misses        157      155       -2     
Impacted Files Coverage Δ
...cli/src/build/webpack/plugins/NativeFiles/index.ts 100.00% <ø> (ø)
packages/remax-wechat/src/node/index.ts 100.00% <ø> (ø)
packages/remax-runtime/src/Container.ts 98.33% <100.00%> (+1.78%) ⬆️
packages/remax-runtime/src/VNode.ts 100.00% <100.00%> (ø)
...ges/remax-runtime/src/hostConfig/diffProperties.ts 100.00% <100.00%> (ø)
packages/remax-runtime/src/hostConfig/index.ts 97.61% <100.00%> (-0.06%) ⬇️
packages/remax-runtime/src/propsAlias.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b7f1c...2c87f6c. Read the comment docs.

@yesmeck
Copy link
Member

yesmeck commented May 28, 2020

CI

@@ -1,6 +1,6 @@
<template name="REMAX_TPL">
<block tt:for="{{tree.root.children}}" tt:key="{{id}}">
<template is="{{'REMAX_TPL_' + item.type}}" data="{{i: item}}" />
<block tt:for="{{root.children}}" tt:key="*this">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*this 是什么

@Darmody
Copy link
Contributor Author

Darmody commented May 28, 2020 via email

@Darmody Darmody merged commit 4709bda into master Jun 1, 2020
@Darmody Darmody deleted the refactor-update-props branch June 1, 2020 05:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants