feat: 支持运行时插件 #988

yesmeck · 2020-05-22T18:28:46Z

close #983

文档 https://remax-git-runtime-plugin.remaxjs.now.sh/guide/advanced/plugin#registerruntimeplugin

vercel · 2020-05-22T18:28:49Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/f4cnbiwin
✅ Preview: https://remax-git-runtime-plugin.remaxjs.now.sh

codesandbox-ci · 2020-05-22T18:31:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27b54cf:

Sandbox	Source
immutable-smoke-rkeg9	Configuration

close #983

codecov · 2020-05-23T04:38:45Z

Codecov Report

Merging #988 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   95.53%   95.60%   +0.06%     
==========================================
  Files         330      331       +1     
  Lines        3497     3526      +29     
  Branches      499      502       +3     
==========================================
+ Hits         3341     3371      +30     
+ Misses        156      155       -1

Impacted Files	Coverage Δ
packages/remax-cli/src/build/utils/alias.ts	`100.00% <ø> (ø)`
packages/remax-cli/src/API.ts	`100.00% <100.00%> (ø)`
...ackages/remax-cli/src/build/webpack/config.mini.ts	`100.00% <100.00%> (ø)`
packages/remax-runtime/src/PluginDriver.ts	`100.00% <100.00%> (ø)`
packages/remax-runtime/src/createAppConfig.ts	`100.00% <100.00%> (ø)`
packages/remax-runtime/src/createPageConfig.ts	`100.00% <100.00%> (ø)`
packages/remax-runtime/src/index.ts	`100.00% <100.00%> (ø)`
...ages/remax-cli/src/build/webpack/plugins/Define.ts	`98.14% <0.00%> (+1.85%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc1028...27b54cf. Read the comment docs.

Darmody · 2020-05-23T07:34:34Z

packages/remax-cli/src/__tests__/integration/fixtures/lifeCycle/expected/app.js

@@ -1,22 +1,24 @@
 require('./runtime.js');
-(my["webpackJsonp"] = my["webpackJsonp"] || []).push([[1],[
-/* 0 */
+require('./remax-vendors.js');


为啥这个会有变化

原来这里写错了 https://github.com/remaxjs/remax/pull/988/files#diff-ca3d11e143e4f3c801c856f09cb0122dR81

Darmody · 2020-05-23T07:36:39Z

docs/guide/advanced/plugin.md

+ onAppConfig(config) {
+ const onLaunch = config.onLaunch;
+ config.onLaunch = () => {
+ console.log('onLaunch');


看起来他有可能把 config 弄坏掉？

Do at your own risk

noyobo · 2020-05-26T01:50:28Z

packages/remax-cli/src/build/webpack/config.mini.ts

+ const pluginTemplate = fs.readFileSync(path.resolve(__dirname, '../../../template/plugin.js.ejs'), 'utf-8');
+ const pluginPath = winPath(
+ path.join(
+ path.resolve(path.dirname(require.resolve('@remax/runtime')), '..'),


path.dirname(require.resolve('@remax/runtime/package.json')) 更简洁，也不受 main 等字段影响

noyobo

👍

Darmody · 2020-05-26T08:57:31Z

开发者要怎么给插件传参数？

yesmeck · 2020-05-26T08:58:15Z

webpack.DefinePlugin

Darmody · 2020-05-26T08:59:24Z

webpack.DefinePlugin

运行时的参数呢？

yesmeck · 2020-05-26T09:00:08Z

就用 webpack.DefinePlugin 传进去

juvham · 2020-08-07T05:14:03Z

运行时插件能否给个demo。文档的信息太少了一头雾水

yesmeck requested review from noyobo and Darmody May 22, 2020 18:28

yesmeck force-pushed the runtime-plugin branch from 0864094 to 39502a3 Compare May 22, 2020 18:32

vercel bot deployed to Preview May 22, 2020 18:32 View deployment

yesmeck force-pushed the runtime-plugin branch from 39502a3 to eccee93 Compare May 22, 2020 18:43

vercel bot deployed to Preview May 22, 2020 18:43 View deployment

feat: 支持运行时插件

ee54cf3

close #983

yesmeck force-pushed the runtime-plugin branch from eccee93 to ee54cf3 Compare May 23, 2020 04:31

vercel bot deployed to Preview May 23, 2020 04:32 View deployment

vercel bot deployed to Preview May 23, 2020 05:41 View deployment

vercel bot deployed to Preview May 23, 2020 05:54 View deployment

vercel bot deployed to Preview May 23, 2020 06:08 View deployment

yesmeck force-pushed the runtime-plugin branch from 7f5d76d to 859283b Compare May 23, 2020 06:29

vercel bot deployed to Preview May 23, 2020 06:29 View deployment

yesmeck force-pushed the runtime-plugin branch from 859283b to f915f3a Compare May 23, 2020 06:36

Darmody reviewed May 23, 2020

View reviewed changes

vercel bot requested a deployment to Preview May 25, 2020 04:12 Abandoned

yesmeck force-pushed the runtime-plugin branch from d4830ae to d5c3209 Compare May 25, 2020 04:31

vercel bot requested a deployment to Preview May 25, 2020 04:31 Abandoned

vercel bot deployed to Preview May 25, 2020 04:47 View deployment

yesmeck force-pushed the runtime-plugin branch from 034bba7 to d5c3209 Compare May 25, 2020 08:59

noyobo reviewed May 26, 2020

View reviewed changes

vercel bot deployed to Preview May 26, 2020 06:37 View deployment

vercel bot deployed to Preview May 26, 2020 06:51 View deployment

vercel bot deployed to Preview May 26, 2020 07:06 View deployment

vercel bot deployed to Preview May 26, 2020 07:16 View deployment

vercel bot deployed to Preview May 26, 2020 07:29 View deployment

yesmeck force-pushed the runtime-plugin branch from 3ea8777 to 2ffa768 Compare May 26, 2020 07:38

vercel bot deployed to Preview May 26, 2020 07:38 View deployment

yesmeck force-pushed the runtime-plugin branch from 2ffa768 to 7ad9f99 Compare May 26, 2020 08:17

vercel bot deployed to Preview May 26, 2020 08:17 View deployment

yesmeck force-pushed the runtime-plugin branch from 7ad9f99 to e96154c Compare May 26, 2020 09:02

vercel bot deployed to Preview May 26, 2020 09:02 View deployment

fix: fix runtime plugin path

27b54cf

yesmeck force-pushed the runtime-plugin branch from e96154c to 27b54cf Compare May 26, 2020 09:15

vercel bot deployed to Preview May 26, 2020 09:15 View deployment

yesmeck merged commit 3a59fff into master May 26, 2020

yesmeck deleted the runtime-plugin branch May 26, 2020 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 支持运行时插件 #988

feat: 支持运行时插件 #988

yesmeck commented May 22, 2020 •

edited

Loading

vercel bot commented May 22, 2020 •

edited

Loading

codesandbox-ci bot commented May 22, 2020 •

edited

Loading

codecov bot commented May 23, 2020 •

edited

Loading

Darmody May 23, 2020

yesmeck May 23, 2020

Darmody May 23, 2020

yesmeck May 23, 2020

Darmody May 23, 2020

noyobo May 26, 2020

noyobo left a comment

Darmody commented May 26, 2020

yesmeck commented May 26, 2020

Darmody commented May 26, 2020

yesmeck commented May 26, 2020

juvham commented Aug 7, 2020

feat: 支持运行时插件 #988

feat: 支持运行时插件 #988

Conversation

yesmeck commented May 22, 2020 • edited Loading

vercel bot commented May 22, 2020 • edited Loading

codesandbox-ci bot commented May 22, 2020 • edited Loading

codecov bot commented May 23, 2020 • edited Loading

Codecov Report

Darmody May 23, 2020

Choose a reason for hiding this comment

yesmeck May 23, 2020

Choose a reason for hiding this comment

Darmody May 23, 2020

Choose a reason for hiding this comment

yesmeck May 23, 2020

Choose a reason for hiding this comment

Darmody May 23, 2020

Choose a reason for hiding this comment

noyobo May 26, 2020

Choose a reason for hiding this comment

noyobo left a comment

Choose a reason for hiding this comment

Darmody commented May 26, 2020

yesmeck commented May 26, 2020

Darmody commented May 26, 2020

yesmeck commented May 26, 2020

juvham commented Aug 7, 2020

yesmeck commented May 22, 2020 •

edited

Loading

vercel bot commented May 22, 2020 •

edited

Loading

codesandbox-ci bot commented May 22, 2020 •

edited

Loading

codecov bot commented May 23, 2020 •

edited

Loading