-
Notifications
You must be signed in to change notification settings - Fork 364
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/yesmeck/remax/7b0l3exes |
import { isHostComponent as isAlipayHostComponent } from './adapters/alipay/components/factory'; | ||
import { isHostComponent as isToutiaoHostComponent } from './adapters/toutiao/components/factory'; | ||
|
||
export function isHostComponent(name: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在 #324 中对 factory 做了统一,那个PR里面再对这个方法优化。
加个测试 |
@yesmeck 也许我们该引导开发者使用原生的属性命名规范了 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2cd2bef:
|
嗯,我先看看CI |
啥意思 |
就是不用 react 风格了,直接 |
好处是啥 |
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 90.46% 91.99% +1.53%
==========================================
Files 174 180 +6
Lines 2213 2549 +336
Branches 296 303 +7
==========================================
+ Hits 2002 2345 +343
+ Misses 210 203 -7
Partials 1 1
Continue to review full report at Codecov.
|
使用自定义组件是原生规范,host组件是 react 规范,有点割裂 |
还行吧 |
7521934
to
11d226f
Compare
11d226f
to
ee78f02
Compare
ee78f02
to
596a4bf
Compare
加个 render 自定义组件出来的 VNode 的测试。 |
596a4bf
to
2cd2bef
Compare
🚀 |
🐂🍺覆盖率涨了不少 |
fix #357