Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix(wechat): AdCustom、KeyboardAccessory 组件找不到模板 #1807

Merged
merged 1 commit into from
Dec 31, 2021
Merged

fix(wechat): AdCustom、KeyboardAccessory 组件找不到模板 #1807

merged 1 commit into from
Dec 31, 2021

Conversation

rikumi
Copy link
Contributor

@rikumi rikumi commented Dec 31, 2021

No description provided.

@rikumi rikumi changed the title fix: AdCustom 组件找不到模板 fix(wechat): AdCustom 组件找不到模板 Dec 31, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 31, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f883d53:

Sandbox Source
one Configuration

@watsonhaw5566
Copy link
Contributor

watsonhaw5566 commented Dec 31, 2021

麻烦再在 remax/wechat 下使用 yarn test -u 更新一下 AdCustom 快照。您的这个单测报错了。

@rikumi rikumi changed the title fix(wechat): AdCustom 组件找不到模板 fix(wechat): AdCustom、KeyboardAccessory 组件找不到模板 Dec 31, 2021
@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #1807 (f883d53) into master (909f5cc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1807   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files         390      390           
  Lines        4737     4737           
  Branches      682      682           
=======================================
  Hits         4279     4279           
  Misses        449      449           
  Partials        9        9           
Impacted Files Coverage Δ
.../remax-wechat/src/hostComponents/AdCustom/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909f5cc...f883d53. Read the comment docs.

@watsonhaw5566
Copy link
Contributor

@rikumi keyboard-accessory 的修复也不是这样的,keyboard-accessory的使用有点特别。

感觉这里在remax有点麻烦,我还不会怎么处理这个。 taro 是这样处理的。NervJS/taro#9548

@rikumi
Copy link
Contributor Author

rikumi commented Dec 31, 2021

@rikumi keyboard-accessory 的修复也不是这样的,keyboard-accessory的使用有点特别。

感觉这里在remax有点麻烦,我还不会怎么处理这个。 taro 是这样处理的。NervJS/taro#9548

明白,我先去掉它

@yesmeck yesmeck merged commit eb581e3 into remaxjs:master Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants