Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: rollup watch #148

Closed
wants to merge 2 commits into from
Closed

fix: rollup watch #148

wants to merge 2 commits into from

Conversation

Crayonn
Copy link
Contributor

@Crayonn Crayonn commented Aug 25, 2019

修复app.config.js无法watch问题, 现在删除page文件夹后也会触发build的错误提示同时增加page路径的验证

不知道我这种修改方式合理不。

修复app.config.js无法watch问题, 现在删除page文件夹后也会触发build的错误提示同时增加page路径的验证
@Darmody
Copy link
Contributor

Darmody commented Aug 26, 2019

是可以解决这个 #45 issue 下几个问题吗

@Crayonn
Copy link
Contributor Author

Crayonn commented Aug 26, 2019

上边两个问题是可以解决的,目前监听的是import文件以及appconfig文件,src下边全部文件的包括没有引入的文件吗,没有引入的文件删除新增这些操作,这种是不是打包会太频繁了?
我现在的思路主要是app config相当于是独立的配置文件,给了它单独的文件监听,其他的还是用rollup watch模块启用了chokidar而且开启了轮训,这样文件夹的删除会被监听到。

@Darmody
Copy link
Contributor

Darmody commented Aug 26, 2019

@Crayonn 因为我们支持原生代码,原生代码是没有import的。所以需要监听所有文件。
或者监听 src/native 下面的所有文件,这个目录是原生代码。

新增 page,也会动态加入 entry 吗?

@Crayonn
Copy link
Contributor Author

Crayonn commented Aug 26, 2019

在app config中新增的page是可以的。可以做到监听原生模块的代码,将模块中的特殊文件集合做成配置吧,这样可以控制一点,因为这部分文件是需要重新编译整个项目的。

@Darmody
Copy link
Contributor

Darmody commented Aug 26, 2019

在app config中新增的page是可以的,可以做到监听原生模块的代码,将模块中的特殊文件集合做成配置吧,这样可以控制一点,因为这部分文件是需要重新编译整个项目的

👍

晚上我跑起来试试看

@Darmody
Copy link
Contributor

Darmody commented Aug 26, 2019

不要 mege master,用 rebase 的方式

@Crayonn
Copy link
Contributor Author

Crayonn commented Aug 26, 2019

好的,我稍晚点把分支整理一下,正好我把特殊的那块做成配置吧,这样会更好一点

Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 26, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 26, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 28, 2019
@Darmody
Copy link
Contributor

Darmody commented Aug 28, 2019

#173

@Darmody Darmody closed this Aug 28, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 29, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Crayonn added a commit to Crayonn/remax that referenced this pull request Aug 30, 2019
Darmody pushed a commit that referenced this pull request Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants