Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 修复 one 的 Input 在微信真机会闪烁的问题 #1264

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 1, 2020

fix #1240

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/7lbsjdzv9
✅ Preview: https://remax-git-fix-one-input-blink.remaxjs.vercel.app

if (!controlled) {
this.setState({ value: e.target.value });
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试过么?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 84012fd:

Sandbox Source
remaxjs/examples: one Configuration

@Darmody Darmody marked this pull request as ready for review September 14, 2020 06:03
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1264 into master will decrease coverage by 0.00%.
The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         350      350              
  Lines        3758     3779      +21     
  Branches      569      569              
==========================================
+ Hits         3584     3604      +20     
  Misses        172      172              
- Partials        2        3       +1     
Impacted Files Coverage Δ
packages/remax-one/src/createHostComponent.ts 91.01% <83.87%> (+1.97%) ⬆️
...ckages/remax-one/src/hostComponents/Input/index.ts 97.77% <91.66%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7ac2a...84012fd. Read the comment docs.

@Darmody Darmody merged commit 7721da2 into master Sep 14, 2020
@Darmody Darmody deleted the fix-one-input-blink branch September 14, 2020 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] remax/one 的 Input 非受控模式下在微信端会闪烁
2 participants