Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 修复remax的picker组件在飞书小程序中传mode属性不生效的问题 #1180

Merged
merged 5 commits into from
Jul 24, 2020

Conversation

ShiTuoCheng
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/diiecw9ui
✅ Preview: https://remax-git-fork-shituocheng-fix-toutiao-picker-mode.remaxjs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 99454ba:

Sandbox Source
remaxjs/examples: one Configuration

@Darmody
Copy link
Contributor

Darmody commented Jul 23, 2020

cli 的测试 snapshot 需要更新一下

@ShiTuoCheng
Copy link
Contributor Author

cli 的测试 snapshot 需要更新一下

done

@Darmody
Copy link
Contributor

Darmody commented Jul 23, 2020

cli 的测试 snapshot 需要更新一下

done

额,你是不是手动更新的 snapshot?应该通过 yarn test -u 来更新

@ShiTuoCheng
Copy link
Contributor Author

cli 的测试 snapshot 需要更新一下

done

额,你是不是手动更新的 snapshot?应该通过 yarn test -u 来更新

截屏2020-07-23 下午5 48 49

本地运行test -u报错,不知道是什么原因。

@yesmeck
Copy link
Member

yesmeck commented Jul 23, 2020

@ShiTuoCheng 先在根目录 yarn build 下

@ShiTuoCheng
Copy link
Contributor Author

@ShiTuoCheng 先在根目录 yarn build 下

OK 可以了🙏

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1180   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         350      350           
  Lines        3693     3693           
  Branches      520      520           
=======================================
  Hits         3518     3518           
  Misses        173      173           
  Partials        2        2           
Impacted Files Coverage Δ
...es/remax-toutiao/src/hostComponents/Picker/node.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c4d4a...99454ba. Read the comment docs.

@Darmody
Copy link
Contributor

Darmody commented Jul 24, 2020

LGTM

@Darmody Darmody merged commit 009bd6d into remaxjs:master Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants