feat: web端支持自定义模板 #1115

JesuisTong · 2020-06-24T13:07:45Z

No description provided.

vercel · 2020-06-24T13:07:49Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/9mgj4n6b9
✅ Preview: https://remax-git-fork-jesuistong-feat-custom-web-template.remaxjs.vercel.app

codesandbox-ci · 2020-06-24T13:11:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bfed21:

Sandbox	Source
remaxjs/examples: one	Configuration

Darmody · 2020-06-28T02:09:32Z

packages/remax-cli/src/build/webpack/config.web.ts

@@ -94,7 +94,7 @@ export default function webpackConfig(api: API, options: Options): webpack.Confi

 config.plugin('html-webpack-plugin').use(HtmlWebpackPlugin, [
 {
- template: path.resolve(__dirname, '../../../template/index.html.ejs'),


是不是直接通过 configWebpack 修改 html-webpack-plugin 就可以满足需求了？

是不是直接通过 configWebpack 修改 html-webpack-plugin 就可以满足需求了？

是的是的。自己接管就好了。
不过不能更改根节点的id（虽然感觉这是伪需求）。

yesmeck · 2020-06-28T02:25:04Z

不如参考 CRA 吧 https://create-react-app.dev/docs/using-the-public-folder/#changing-the-html

codecov · 2020-06-28T04:18:02Z

Codecov Report

Merging #1115 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   95.27%   95.29%   +0.02%     
==========================================
  Files         350      351       +1     
  Lines        3682     3698      +16     
  Branches      515      521       +6     
==========================================
+ Hits         3508     3524      +16     
  Misses        172      172              
  Partials        2        2

Impacted Files	Coverage Δ
packages/remax-cli/src/build/webpack/config.web.ts	`96.66% <100.00%> (+0.11%)`	⬆️
packages/remax-runtime/src/VNode.ts	`100.00% <0.00%> (ø)`
packages/remax-runtime/src/index.ts	`100.00% <0.00%> (ø)`
packages/remax-runtime/src/createPageConfig.ts	`100.00% <0.00%> (ø)`
packages/remax-runtime/src/createPageWrapper.ts	`100.00% <0.00%> (ø)`
...ackages/remax-ali/src/hostComponents/Video/node.ts	`100.00% <0.00%> (ø)`
...ckages/remax-ali/src/hostComponents/Video/index.ts	`100.00% <0.00%> (ø)`
...kages/remax-wechat/src/hostComponents/View/node.ts	`100.00% <0.00%> (ø)`
...emax-runtime/src/SyntheticEvent/stopPropagation.ts	`100.00% <0.00%> (ø)`
packages/remax-runtime/src/PageInstanceContext.ts
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7547c1...9bfed21. Read the comment docs.

JesuisTong · 2020-07-02T07:27:35Z

https://github.com/facebook/create-react-app/blob/4784997f0682e75eb32a897b4ffe34d735912e6c/packages/react-scripts/config/webpack.config.js#L576
https://github.com/facebook/create-react-app/blob/4784997f0682e75eb32a897b4ffe34d735912e6c/packages/react-scripts/config/paths.js#L65

看create-react-app貌似直接用的public下的index.html，不如也直接拿public下的？

yesmeck · 2020-07-02T07:28:58Z

@JesuisTong CRA 的 cli 跟脚手架是绑定的，所以可以这么做。我们不行的。

JesuisTong · 2020-07-02T07:46:05Z

@JesuisTong CRA 的 cli 跟脚手架是绑定的，所以可以这么做。我们不行的。

俺不太明白。。🤦‍♀️

yesmeck · 2020-07-02T07:47:55Z

就是对我们来说直接去读 public/index.html 对已有的项目是个 breaking change

JesuisTong · 2020-07-02T07:52:46Z

就是对我们来说直接去读 public/index.html 对已有的项目是个 breaking change

哦哦，那感觉最好还是用参数控制来显式的声明一下template的path？

yesmeck · 2020-07-02T07:55:06Z

那没必要，就现在这样挺好的。文档补一下就可以了。

JesuisTong · 2020-07-02T07:58:39Z

🙆

Darmody · 2020-07-02T10:33:15Z

就是对我们来说直接去读 public/index.html 对已有的项目是个 breaking change

我们现在如果 public 目录里有 index.html 就是会覆盖掉默认的 index.html 吧？

Darmody · 2020-07-06T13:23:00Z

packages/remax-cli/src/build/webpack/config.web.ts

@@ -91,10 +91,12 @@ export default function webpackConfig(api: API, options: Options): webpack.Confi
 .plugin('webpack-copy-plugin')
 .use(CopyPlugin, [[{ from: publicDirPath, to: path.join(options.cwd, options.output) }]]);
 }
-
+ console.log(path.join(publicDirPath, 'index.html'), options.cwd);


Suggested change

console.log(path.join(publicDirPath, 'index.html'), options.cwd);

Darmody · 2020-07-06T13:25:22Z

docs/guide/basic/public.md

+
+<!-- TODO: 这个写什么版本？ -->
+
+> 2.6.0 开始支持
+


Suggested change



> 2.6.0 开始支持

> 2.7.0 开始支持

Darmody · 2020-07-06T13:26:13Z

vercel bot deployed to Preview June 24, 2020 13:07 View deployment

Darmody reviewed Jun 28, 2020

View reviewed changes

vercel bot temporarily deployed to Preview June 28, 2020 04:11 Inactive

vercel bot deployed to Preview June 28, 2020 04:13 View deployment

TongZ and others added 4 commits July 6, 2020 15:56

feat: web端支持自定义模板

d8f73e8

默认优先用public下的Index.html

59ce423

删除无用type

8adc54d

chore: 测试用例和文档补充

6c53418

JesuisTong force-pushed the feat/custom-web-template branch from a78b7b6 to 6c53418 Compare July 6, 2020 08:09

vercel bot deployed to Preview July 6, 2020 08:10 View deployment

Darmody reviewed Jul 6, 2020

View reviewed changes

fix: 删除无用console和注释

c389a5a

vercel bot temporarily deployed to Preview July 6, 2020 14:04 Inactive

vercel bot deployed to Preview July 6, 2020 14:06 View deployment

test: update test

9bfed21

vercel bot deployed to Preview July 9, 2020 01:40 View deployment

Darmody merged commit c602637 into remaxjs:master Jul 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: web端支持自定义模板 #1115

feat: web端支持自定义模板 #1115

JesuisTong commented Jun 24, 2020

vercel bot commented Jun 24, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 24, 2020 •

edited

Loading

Darmody Jun 28, 2020

JesuisTong Jun 28, 2020

yesmeck commented Jun 28, 2020

codecov bot commented Jun 28, 2020 •

edited

Loading

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020 •

edited

Loading

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020

JesuisTong commented Jul 2, 2020

Darmody commented Jul 2, 2020

Darmody Jul 6, 2020

Darmody Jul 6, 2020

Darmody commented Jul 6, 2020

feat: web端支持自定义模板 #1115

feat: web端支持自定义模板 #1115

Conversation

JesuisTong commented Jun 24, 2020

vercel bot commented Jun 24, 2020 • edited Loading

codesandbox-ci bot commented Jun 24, 2020 • edited Loading

Darmody Jun 28, 2020

Choose a reason for hiding this comment

JesuisTong Jun 28, 2020

Choose a reason for hiding this comment

yesmeck commented Jun 28, 2020

codecov bot commented Jun 28, 2020 • edited Loading

Codecov Report

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020 • edited Loading

JesuisTong commented Jul 2, 2020

yesmeck commented Jul 2, 2020

JesuisTong commented Jul 2, 2020

Darmody commented Jul 2, 2020

Darmody Jul 6, 2020

Choose a reason for hiding this comment

Darmody Jul 6, 2020

Choose a reason for hiding this comment

Darmody commented Jul 6, 2020

vercel bot commented Jun 24, 2020 •

edited

Loading

codesandbox-ci bot commented Jun 24, 2020 •

edited

Loading

codecov bot commented Jun 28, 2020 •

edited

Loading

yesmeck commented Jul 2, 2020 •

edited

Loading