Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG make sure rerenders work and set permissions correctly #2503

Merged
merged 15 commits into from
Apr 23, 2024
Merged

BUG make sure rerenders work and set permissions correctly #2503

merged 15 commits into from
Apr 23, 2024

Conversation

beckermr
Copy link
Contributor

This PR tries to fix #2500

beckermr
beckermr commented Apr 23, 2024
View reviewed changes
docker/run_bot_task.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.67347% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 23.99%. Comparing base (703f273) to head (d4473a5).
Report is 6 commits behind head on master.

❗ Current head d4473a5 differs from pull request most recent head 8b4897c. Consider uploading reports for the commit 8b4897c to get more accurate results

Files Patch % Lines
tests/test_container_tasks.py 72.34% 13 Missing ⚠️
conda_forge_tick/os_utils.py 93.02% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2503       +/-   ##
===========================================
- Coverage   71.57%   23.99%   -47.59%     
===========================================
  Files         104      103        -1     
  Lines       10427    10491       +64     
===========================================
- Hits         7463     2517     -4946     
- Misses       2964     7974     +5010

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr beckermr merged commit 2c01a81 into master Apr 23, 2024
2 checks passed
@beckermr beckermr deleted the empty-rerend branch April 23, 2024 20:12
@h-vetinari h-vetinari mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid arch migrator PRs to maintenance branches that already have the arches
1 participant
@beckermr