Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageryLayer readonly imageryProvider prop #664

Closed
TheMrCam opened this issue Jun 21, 2024 · 0 comments · Fixed by #665
Closed

ImageryLayer readonly imageryProvider prop #664

TheMrCam opened this issue Jun 21, 2024 · 0 comments · Fixed by #665

Comments

@TheMrCam
Copy link
Contributor

TheMrCam commented Jun 21, 2024 •
edited
Loading

Overview

The Resium docs and Cesium docs agree that ImageryLayer#imageryProvider is a readonly property.
It appears that Resium does not accurately respect that, and as a result the ImageryLayer isn't being recreated on prop change.

Is this an issue?

I primarily wanted to make this issue to ask permission to create a small PR that remedies the problem by moving 'imageryProvider' from otherProps to cesiumReadonlyProps, as I already have and use this as a custom Resium component downstream.

However, there's entirely a chance that I'm actually missing something or doing something slightly incorrectly, in which case I wouldn't want to introduce any changes to Resium that would affect other developers.
TheMrCam added a commit to TheMrCam/resium that referenced this issue Jun 21, 2024
@TheMrCam
Fix ImageryLayer readonly imageryProvider prop
a26c3bc 
Fixes lack of recreation on imageryProvider prop update by adding it to
the cesiumReadonlyProps array, which is where it belongs according to
the Cesium and Resium documentation.

Addresses reearth#664
@TheMrCam TheMrCam mentioned this issue Jun 21, 2024
Merged
keiya01 added a commit that referenced this issue Jul 9, 2024
@TheMrCam @keiya01
fix: change imageryProvider to readonly (#665)
3f790ea 
* Fix ImageryLayer readonly imageryProvider prop

Fixes lack of recreation on imageryProvider prop update by adding it to
the cesiumReadonlyProps array, which is where it belongs according to
the Cesium and Resium documentation.

Addresses #664

* Remove unnecessary type definition

---------

Co-authored-by: keiya sasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change imageryProvider to readonly TheMrCam/resium
1 participant
@TheMrCam