Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra reducers should have a more descriptive name #4476

Closed
esharmony opened this issue Jun 21, 2024 · 2 comments
Closed

Extra reducers should have a more descriptive name #4476

esharmony opened this issue Jun 21, 2024 · 2 comments

Comments

@esharmony
Copy link

Just a thought, but the name extra reducers I think is a bit weak, maybe I am wrong and missing something, but something like internalReducers would be more descriptive as they respond to actions that are not directly called on the slice.

Not a biggy, just a thought :)

@markerikson
Copy link
Collaborator

I'm the one who's responsible for coming up with that name back in 2019 :)

I agree that extraReducers is not a great name. But, there weren't any other really good alternatives suggested at the time, and now that it's been around for several years we aren't going to change it. Sorry!

@markerikson markerikson closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
@esharmony
Copy link
Author

Understood, love em though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants