-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ForkedTaskApi to include API #3314
Labels
Milestone
Comments
I'm not sure why we only included the miniature version of the API in Want to try making that change? |
Yeah can look into it next week |
Still open to having this added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having considered porting a lot of code from saga to listeners, I've noticed that I am reaching for the same pattern which is a bit verbose in order to have deeply nested forking:
Example:
When in reality, the
ForkedTaskApi
could just include things from the parent, likegetState()
,dispatch()
, andfork()
. Not only would this make the code easier to readapi.fork(doAnotherThing))
, but it would also mean the type API for both the fork and the task is the same.The text was updated successfully, but these errors were encountered: