Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useActionsResult #71

Open
jifeon opened this issue Jun 5, 2016 · 2 comments
Open

Remove useActionsResult #71

jifeon opened this issue Jun 5, 2016 · 2 comments

Comments

@jifeon
Copy link
Contributor

jifeon commented Jun 5, 2016

We have stores now and can set data in one action and get it inside another, useActionsResult is used to get actions result from previous actions, it's rudiment and should be removed

@maZahaca
Copy link
Member

@jifeon could you clarify that issue a bit more?

@jifeon
Copy link
Contributor Author

jifeon commented Jan 2, 2017

Now it looks like:

{
  actions: [],
  name: 'blah',
  useActionsResult: true
}

so in last action you return a promise which resolves with value, which will saved as blah. It imposes limitations:

  • You should have actions beside the property which you wanna parse to
  • Last action should return desired result

In the same time we have stores and can use action { type: 'any_type', set: 'key_name_in_storage' } at any place in parsing process and use saved value in a rule { get: 'key_name_in_storage' }

That's why I think useActionsResult is redundant and must be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants