Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing pointerEvents style attribute #14

Closed
jaredly opened this issue Jun 14, 2017 · 5 comments
Closed

Missing pointerEvents style attribute #14

jaredly opened this issue Jun 14, 2017 · 5 comments

Comments

@jaredly
Copy link
Contributor

jaredly commented Jun 14, 2017

No description provided.

@AgtLucas
Copy link
Contributor

@jaredly are you sure? https://github.com/reasonml/reason-react/blob/master/src/reactDOMRe.re#L408 🤔

@glennsl
Copy link
Contributor

glennsl commented Jun 15, 2017 •
edited
Loading

@AgtLucas That's the prop. SVG CSS attributes are largely missing: https://github.com/reasonml/reason-react/blob/master/src/reactDOMRe.re#L915

As are lots of others. It's just a matter of adding them.

Meanwhile, unsafeAddProp can be used (which is a bit misleadingly named, it doesn't actually mutate)

@AgtLucas
Copy link
Contributor

@glennsl Ah, I see. I'll add then. :)

@AgtLucas AgtLucas mentioned this issue Jun 15, 2017
Merged
@chenglou chenglou mentioned this issue Jun 15, 2017
Merged
@chenglou
Copy link
Member

Do these above 2 solve this?

@jaredly
Copy link
Contributor Author

jaredly commented Jun 20, 2017

yup this is solved

@jaredly jaredly closed this as completed Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaredly @chenglou @AgtLucas @glennsl