Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document subscription patterns #115

Closed
rickyvetter opened this issue Nov 4, 2017 · 3 comments
Closed

Document subscription patterns #115

rickyvetter opened this issue Nov 4, 2017 · 3 comments
Assignees

Comments

@rickyvetter
Copy link
Contributor

We should look into first-classing as much as possible here, but once we've gotten to where we are comfortable we should document how deal with various sub/release apis. They very widely and some are more friendly to our React patterns than others.

@rickyvetter rickyvetter self-assigned this Nov 4, 2017
@glennsl
Copy link
Contributor

glennsl commented Nov 4, 2017

This is somewhat related to #102 as well I think.

@rickyvetter
Copy link
Contributor Author

Agreed. #102 is a specific case of what I’m worried about here - where RR is less intuitive than React JS. We need to either design this case away or provide clear instruction.

@alex35mil
Copy link
Contributor

@rickyvetter @chenglou @glennsl On #102 case: AFAICT w/ current api it can be handled by copying props to state and wrapping handler w/ self.handle before passing it to window.addEventListener. Should this be added to docs? Or there's a better way to handle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants