Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frozen Architecture] Consider automatic cleanup of intermittent versions #332

Open
cmelchior opened this issue Jul 2, 2021 · 2 comments

Comments

@cmelchior
Copy link
Contributor

We only sweep the list of intermittent versions (RealmReferences) when the Realm is updated. This means that we might be holding on to memory longer than needed.

We should consider if it is worth implementing a background cleaner that cleans up the list at regular intervals.

Low priority.

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 13, 2021

➤ Christan Melchior commented:

Will be closed by #598

@rorbech
Copy link
Contributor

rorbech commented Jan 19, 2022

➤ Christan Melchior commented:

Will be closed by #598

Updating the user face realm's intermittent versions on the realm_on_realm_change_func_t won't fix this issue. The clean up is still not performed until we iterate the weak references and this is still not automatically detecting when realm references/version are not used anymore. Reacting to the correct realm_on_realm_change_func_t will of course trigger the clean up more often, but it could still make sense to trigger periodically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants