diff --git a/.vscode/settings.json b/.vscode/settings.json index cf8a6e2974..7254e2bf8b 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -4,9 +4,19 @@ "mode": "auto" } ], + "eslint.format.enable": true, + "[javascript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint" + }, + "[typescript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint" + }, + "[typescriptreact]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint" + }, + "typescript.tsdk": "node_modules/typescript/lib", "gitlens.advanced.blame.customArguments": [ "--ignore-revs-file", ".gitignore-revs" - ], - "typescript.tsdk": "node_modules/typescript/lib" -} \ No newline at end of file + ] +} diff --git a/contrib/linting.md b/contrib/linting.md index cc75d9c737..c9c4f99b9e 100644 --- a/contrib/linting.md +++ b/contrib/linting.md @@ -12,12 +12,12 @@ To help yourself keep your code passing linters at all times, it's highly recomm ### Visual Studio Code - Install and enable the ["eslint" extension for VS Code](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). +- Disable any other code formatting extensions (such as Prettier / [`esbenp.prettier-vscode`](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)) for the workspace, as they might interfere with the format enforced by eslint. - Make sure you've enabled "format on save" on your workspace. -Both the eslint plugin and formatting on save can be enabled via the UI or you can Cmd + P, type *"> Preferences Open Workspace Settings (JSON)"* and paste in the following in the `settings` object: +The eslint formatting on save can be enabled via the UI or you can Cmd + P, type *"> Preferences Open Workspace Settings (JSON)"* and paste in the following in the `settings` object: ```json -"eslint.format.enable": true, "editor.formatOnSave": true ```