Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapackage.json doesn't accept year format as -384 but only -0384 #536

Open
whalekeykeeper opened this issue Jul 7, 2023 · 2 comments
Open

datapackage.json doesn't accept year format as -384 but only -0384 #536

whalekeykeeper opened this issue Jul 7, 2023 · 2 comments
Assignees
@whalekeykeeper

Comments

@whalekeykeeper
Copy link
Contributor

CI failed because the birthyear and deathyear in Person.csv doesn't fit datapackage.json.

It makes more sense to have -384 than -0384.

datapackage.json needs an update.
@whalekeykeeper whalekeykeeper self-assigned this Jul 7, 2023
@duncdrum
Copy link
Member

duncdrum commented Jul 7, 2023

'-0384' is a valid datetype the other is not, I would not try to change the validation behavior, but fix the date

@whalekeykeeper
Copy link
Contributor Author

'-0384' is a valid datetype the other is not, I would not try to change the validation behavior, but fix the date

Get it. Will fix the date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whalekeykeeper whalekeykeeper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duncdrum @whalekeykeeper