Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink automatic discovery of commands #568

Open
thymikee opened this issue Jul 19, 2019 · 2 comments
Open

Rethink automatic discovery of commands #568

thymikee opened this issue Jul 19, 2019 · 2 comments
Labels
discussion no-stale-bot This issue cannot be marked as stale by stale bot

Comments

@thymikee
Copy link
Member

By installing a 3rd party dependency, which exposed a custom command with a side-effectful code loaded eagerly, CLI bailed on cleanly exiting after executing a command.

See #567 for details.

This scenario revealed a flaw in our plugin design, where any package may, consciously or not, abuse the user workflow. We should rethink the automatic discovery of user configs (and in turn commands). Maybe it's not that big of a deal, but maybe we can do something to make it harder to exploit. Or at least hard exit after the command was finished, to not let it go rogue.

cc @grabbou @satya164 @cpojer

@thecodrr
Copy link
Contributor

thecodrr commented Aug 6, 2019

Changing template.config from JS to JSON would be a good step in this regard. But that's a breaking change and maybe should be implemented in 3.x.

@github-actions
Copy link

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Nov 30, 2022
@github-actions github-actions bot closed this as completed Dec 8, 2022
@thymikee thymikee added no-stale-bot This issue cannot be marked as stale by stale bot and removed stale labels Dec 8, 2022
@thymikee thymikee reopened this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion no-stale-bot This issue cannot be marked as stale by stale bot
Projects
None yet
Development

No branches or pull requests

2 participants