You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By installing a 3rd party dependency, which exposed a custom command with a side-effectful code loaded eagerly, CLI bailed on cleanly exiting after executing a command.
This scenario revealed a flaw in our plugin design, where any package may, consciously or not, abuse the user workflow. We should rethink the automatic discovery of user configs (and in turn commands). Maybe it's not that big of a deal, but maybe we can do something to make it harder to exploit. Or at least hard exit after the command was finished, to not let it go rogue.
There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
By installing a 3rd party dependency, which exposed a custom command with a side-effectful code loaded eagerly, CLI bailed on cleanly exiting after executing a command.
See #567 for details.
This scenario revealed a flaw in our plugin design, where any package may, consciously or not, abuse the user workflow. We should rethink the automatic discovery of user configs (and in turn commands). Maybe it's not that big of a deal, but maybe we can do something to make it harder to exploit. Or at least hard exit after the command was finished, to not let it go rogue.
cc @grabbou @satya164 @cpojer
The text was updated successfully, but these errors were encountered: