Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting 3 times slack notification for same resource reminder #329

Open
singhvikash11 opened this issue Nov 17, 2022 · 2 comments
Open

Getting 3 times slack notification for same resource reminder #329

singhvikash11 opened this issue Nov 17, 2022 · 2 comments

Comments

@singhvikash11
Copy link
Member

singhvikash11 commented Nov 17, 2022

Description
For the same resource expiration guardian send 3 times notification, I am guessing the reordering of var notifications can cause issues.

@bsushmith
Copy link
Member

bsushmith commented Nov 21, 2022

This is a misconfiguration issue from the deployment side due to multiple configurations that need to be set to disable one job -

In code, JobConfig.Enabled is set to true by default (for backward compatibility)

and while checking for jobs that need to be enabled in the server, we check for both access and grants jobs enabled for backward compatibility.

This would necessitate disabling both if we want to run these jobs outside server as part of deployment.

JOBS:
  FETCH_RESOURCES:
    Enabled: false
    Interval: "*/1 * * * *"
  REVOKE_EXPIRED_ACCESS:
    Enabled: false
    Interval: "*/1 * * * *"
  REVOKE_EXPIRED_GRANTS:
    Enabled: false
  EXPIRING_ACCESS_NOTIFICATION:
    Enabled: false
    Interval: "*/1 * * * *"
  EXPIRING_GRANT_NOTIFICATION:
    Enabled: false

We should consider if we can deprecate these backward compatibilities and have only one config moving forward and have JobConfig.Enabled set to false by default.

@rahmatrhd @haveiss @mabdh @utsav-agarwal

@mabdh
Copy link
Member

mabdh commented Nov 21, 2022

@singhvikash11 I would suggest to redact some sensitive data from the screenshot, e.g. url, bq project name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants