Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues, new features and breaking changes #1

Open
ray-x opened this issue Apr 25, 2021 · 10 comments
Open

Known issues, new features and breaking changes #1

ray-x opened this issue Apr 25, 2021 · 10 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ray-x
Copy link
Owner

ray-x commented Apr 25, 2021

Issue:

(Fixed)
(1) Open preview when split windows present may close the split window. It might be caused by an incorrect window id.

(Fixed)
(2) Breaking changes: neovim/neovim#13664. (Fixed)

(merged)
(3) gopls report error 'file:https://' not found in workspace. This is caused gopls is thinking floating windows with syntax on is a 'go' file. Fix is under testing. PR : neovim/nvim-lspconfig#944.

(merged)
(4) Breaking changes neovim floating_windows. neovim changed its' API neovim/neovim#14649
it has some side effects include the position of "apply action" floating window. Will working on them. (May 25)

Improvements

1) Backspace in search prompt
2) Fully configurable
3) PHP, dockerls support

PR welcome

@RobertBuhren
Copy link

Hi,
is this list still up-to-date? I.e., this plugin should not work with nvim 0.5? I just installed it and I get a lot of errors such as windows missing where I expect one or lua errors. Should I file a bug report, or is this expected with nvim 0.5?

Regards,
Robert

@ray-x
Copy link
Owner Author

ray-x commented Jul 18, 2021

Hi,
The list was not up-to-date.

Thanks for trying the plugin and report issue. Could you share your config?

My minium config:

set termguicolors
call plug#begin('~/.vim/plugged')
Plug 'neovim/nvim-lspconfig'
Plug 'nvim-treesitter/nvim-treesitter'

Plug 'ray-x/guihua.lua'
Plug 'ray-x/navigator.lua'

call plug#end()

lua <<EOF
local single = {"", "", "", "", "", "", "", ""}
require"navigator".setup({
  debug = true,
  width = 0.7,
  border = single, -- "single"
})
EOF
set mouse=a
                                                                                                                                                                      

I am tracking neovim upstream. But I can not verify every operating system and setup.

@behzade
Copy link
Contributor

behzade commented Aug 25, 2021

Hi,
I wanted to ask if [d and ]d both going to the next diagnostic is a known issue. Also gopls code actions don't seem to be working if I use jk keys in the float window.
Not sure if this is the correct place to ask.

@ray-x
Copy link
Owner Author

ray-x commented Aug 25, 2021

Please submit a separate issue.
I can not reproduce this issue. It would be great to attach your config and your operation system.
[d should work out of box and it calls neovim lsp API directly. The plugin only provides keymappings. I suspect the gopls was not loaded correctly

@ray-x
Copy link
Owner Author

ray-x commented Aug 25, 2021

Your fix should work. Thanks!

@Corey-Keller
Copy link

You may want to update the documentation to note that folke/lua-dev.nvim is now a strictly enforced mandatory dependency, because opening even just an empty non lua buffer results in:

Error: attempted to load lua-dev.nvim which is not present in plugins table!                                                                                                                                    
Error in packer_compiled: ...vim/site/pack/packer/opt/packer.nvim/lua/packer/load.lua:13: Error: attempted to load lua-dev.nvim which is not present in plugins table!                                          
Please check your config for correctness                                                                                                                                                                        
Press ENTER or type command to continue 

If you don't have lua-dev installed

@ray-x
Copy link
Owner Author

ray-x commented Oct 4, 2021

This behaviour is incorrect. Should be fixed in faab21a

@ray-x ray-x changed the title A list of known issues Known issues and breaking changes Jul 2, 2022
@ray-x ray-x added bug Something isn't working enhancement New feature or request labels Jul 2, 2022
@ray-x ray-x self-assigned this Jul 2, 2022
@ray-x ray-x pinned this issue Jul 2, 2022
@ray-x
Copy link
Owner Author

ray-x commented Jul 2, 2022

image

Moving to new neovim API for key binding

The new way to bind a key is
{ key = 'gr', func = require('navigator.reference').async_ref, desc = 'async_ref' },

doc field is optional
Also as vim.keymap.set() only supported 0.7.x and greater so 0.6.x might no longer works.

@ray-x
Copy link
Owner Author

ray-x commented Jul 12, 2022

Notes.

{ key = 'gr', func = require('navigator.reference').async_ref, ~~doc~~ = 'async_ref' }

is moving to

{ key = 'gr', func = require('navigator.reference').async_ref, **desc** = 'async_ref' },

Also

{ key = "<Leader>re", func = "rename()" }, 

must move to

{ key = "<Leader>re", func = vim.lsp.buf.rename }, 

You can not shorten it to rename()

There was some doc was not updated.

@ray-x ray-x changed the title Known issues and breaking changes Known issues, new features and breaking changes Sep 2, 2022
@ray-x
Copy link
Owner Author

ray-x commented Oct 19, 2022

breaking:
I created a new branch neodev to reflect recent change from lua-dev.
In long term. I may remove neodev support from the plugin as it is not necessary with latest updates from neodev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants