[Autoscaler] Ensure ubuntu is owner of docker host mount folder #13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeerHajAli
reviewed
Jan 20, 2021
| self.ssh_command_runner.run( | ||
| f"mkdir -p {os.path.dirname(host_destination.rstrip('/'))}", | ||
| f"mkdir -p {host_mount_location} && chown -R ubuntu {host_mount_location}", |
There was a problem hiding this comment.
Should this be hard coded to ubuntu or the auth user in the cluster yaml?
There was a problem hiding this comment.
Good point, it should be the ssh user in the cluster yaml
AmeerHajAli
reviewed
Jan 20, 2021
AmeerHajAli
reviewed
Jan 20, 2021
| self.ssh_command_runner.run( | ||
| f"mkdir -p {os.path.dirname(host_source.rstrip('/'))}", | ||
| f"mkdir -p {host_mount_location} && chown -R ubuntu {host_mount_location}", |
There was a problem hiding this comment.
Same as previous comment.
AmeerHajAli
approved these changes
Jan 21, 2021
|
@ericl please merge. |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…project#13579) * change ownership to ubuntu if root * use ssh user in cluster config * formatting Co-authored-by: Nikita Vemuri <[email protected]>
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…er (ray-project#13579)" This reverts commit 556f2be.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…er (ray-project#13579)" This reverts commit 556f2be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Problem: The docker host mount folder is sometimes created with
rootas the owner. Later,rsync_upis run as part of the session startup withubuntuas the user. This leads to an error because it cannot write to the folder.Solution: It seems this folder is only being created in
run_rsync_upandrun_rsync_downso this PR is changing the ownership of the folder toubuntu.ubuntu, no ownership will be changed and no errors will be raised.root, this will fail unless the user is alsoroot. This may affect clusters that have already been created. However, it should be ok if this fails becausersyncwill likely not work on these clusters unless the user runningrsyncisroot.ubuntu, the folder will be created with the owner asubuntu.root, the folder will be created with the owner asroot, but the owner will immediately be changed toubuntu. Becauserootis the user, this shouldn't throw an error and would allowrsyncto work in the future during session startup.Related issue number
Checks
scripts/format.shto lint the changes in this PR.