From 142b462d5e31c42b7d888e222cab2424d962db3c Mon Sep 17 00:00:00 2001 From: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Date: Thu, 15 Jun 2023 18:49:47 -0700 Subject: [PATCH] [autoscaler] fix too many values to unpack (expected 2) bug (#36231) (#36482) Signed-off-by: Lonnie Liu --- python/ray/autoscaler/_private/monitor.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/python/ray/autoscaler/_private/monitor.py b/python/ray/autoscaler/_private/monitor.py index f15e109fc9d40..5f2f5e5b7ee56 100644 --- a/python/ray/autoscaler/_private/monitor.py +++ b/python/ray/autoscaler/_private/monitor.py @@ -399,11 +399,15 @@ def _run(self): self.autoscaler.update() status["autoscaler_update_time"] = time.time() - update_start_time autoscaler_summary = self.autoscaler.summary() - self.emit_metrics( - load_metrics_summary, - autoscaler_summary, - self.autoscaler.all_node_types, - ) + try: + self.emit_metrics( + load_metrics_summary, + autoscaler_summary, + self.autoscaler.all_node_types, + ) + except Exception: + logger.exception("Error emitting metrics") + if autoscaler_summary: status["autoscaler_report"] = asdict(autoscaler_summary) status[ @@ -463,7 +467,7 @@ def emit_metrics(self, load_metrics_summary, autoscaler_summary, node_types): for _, node_type, _ in autoscaler_summary.pending_nodes: pending_node_count[node_type] += 1 - for node_type, count in autoscaler_summary.pending_launches: + for node_type, count in autoscaler_summary.pending_launches.items(): pending_node_count[node_type] += count for node_type in node_types: