Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8.0 ZipExtractor requires .NET 8.0 drivers after compiling as self-contained. #693

Closed
J0nathan550 opened this issue Jun 14, 2024 · 9 comments

Comments

@J0nathan550
Copy link

Yesterday, I was testing auto updating for my WPF application. I tried to test with my friend together to update the application. For me everything went smoothly because I am a developer and have all required drivers.

For him, he had to install .net 8 drivers in order to autoupdate the application.

What to do?

Everything is latest from NuGet.

@ravibpatel
Copy link
Owner

This is similar to #691. You have to compile ZipExtractor with self-contained and compile AutoUpdater.NET with it so it can use self-contained ZipExtractor. You can also use installer as an update file instead of zip file and that may solve this issue too. You can do that by downloading NSIS and converting your zip to installer.

@ravibpatel
Copy link
Owner

ravibpatel commented Jun 15, 2024

Can you tell me which OS are you targeting? I plan to revert to previous behavior where ZipExtractor was compiled using .NET Framework 4.5. It can run without installing anything on Windows 8 and above while keeping the DLL size low.

@J0nathan550
Copy link
Author

Can you tell me which OS are you targeting? I plan to revert to previous behavior where ZipExtractor was compiled using .NET Framework 4.5. It can run without installing anything on Windows 8 and above while keeping the DLL size low.

Targeting all Windows versions that WPF supports.

I believe it's, Windows 7 SP1 and above.

@J0nathan550
Copy link
Author

This is similar to #691. You have to compile ZipExtractor with self-contained and compile AutoUpdater.NET with it so it can use self-contained ZipExtractor. You can also use installer as an update file instead of zip file and that may solve this issue too. You can do that by downloading NSIS and converting your zip to installer.

I would say this is too much fuss, when you expect library to work flawlessly without any 3rd party interaction, like literally compiling library your own, and do other stuff.

I believe there was a version that didn't had this issue? I don't remember which one it was, can you remind?

@ravibpatel
Copy link
Owner

It was v1.8.4. That version used ZipExtractor compiled using .NET Framework. Although that was unintentional. I never received a complaint about this issue with that version. I am thinking of reverting that change and bundling the ZipExtactor compiled using .NET Framework 4.5 in next version. That should fix this issue and make it compatible with Windows 8 or above without installing anything.

@ravibpatel
Copy link
Owner

I went ahead and did the change. Can you try DLL from here?

@J0nathan550
Copy link
Author

I went ahead and did the change. Can you try DLL from here?

Sure, let me try.

@J0nathan550
Copy link
Author

Works, no issues.

image
image1

@ravibpatel
Copy link
Owner

I went ahead and pushed the new release to NuGet. It should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants