Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupdater.NET.Official v1.8.4 does not allow to use several command line arguments #664

Closed
pavel-mitchenko opened this issue Feb 13, 2024 · 1 comment

Comments

@pavel-mitchenko
Copy link

pavel-mitchenko commented Feb 13, 2024

I only can specify one command like argument using section

If I specify several arguments like <args>/qb+! TARGETDIR=C:\installfolder</args> (quiet mode + installation path), then I get the syntax error, because the final command will be msiexec /i Setup.msi "/qb+! TARGETDIR=C:\installfolder". The from args are put to quotes which is wrong. It would work if we have msiexec /i Setup.msi /qb+! TARGETDIR=C:\installfolder

Look like the breaking commit is 7796d0b line 237 processStartInfo.Arguments = Utils.BuildArguments(arguments);

PasteArguments.AppendArgument put everything to quotas if it has white-space or quota

if (argument.Length != 0 && ContainsNoWhitespaceOrQuotes(argument))
        {
            // Simple case - no quoting or changes needed.
            stringBuilder.Append(argument);
        }
        else
        {
            stringBuilder.Append(Quote);
@ravibpatel
Copy link
Owner

I reverted that change as it was unnecessary. Thanks for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants